Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(373)

Issue 194096: For the purposes of the "system color space," use the main display's color space (Closed)

Created:
11 years, 3 months ago by Mark Mentovai
Modified:
9 years, 7 months ago
Reviewers:
Nico, Amanda Walker
CC:
chromium-reviews_googlegroups.com, John Grabowski, brettw, pam+watch_chromium.org
Visibility:
Public.

Description

For the purposes of the "system color space," use the main display's color space instead of a color space derived from the apparently unreliable system ColorSync profile setting. BUG=21658 TEST=Rendering works on Nico's girlfriend's laptop Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=26090

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -9 lines) Patch
M base/mac_util.mm View 1 chunk +13 lines, -9 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Nico
LG Ran my local build without and with this patch. Without the patch, the renderer ...
11 years, 3 months ago (2009-09-13 08:15:38 UTC) #1
Mark Mentovai
Thanks for the review. I tried this out myself on a few machines and the ...
11 years, 3 months ago (2009-09-13 15:09:36 UTC) #2
Amanda Walker
11 years, 3 months ago (2009-09-13 18:53:46 UTC) #3
LGTM!

Powered by Google App Engine
This is Rietveld 408576698