Issue 194095: Fix crash when closing tab with an open http auth sheet.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 194095: Fix crash when closing tab with an open http auth sheet. (Closed)

Created:
11 years, 3 months ago by Nico

Modified:
9 years, 7 months ago

Reviewers:
Avi (use Gerrit)

CC:
chromium-reviews_googlegroups.com, viettrungluu, Mike Mammarella

Visibility:
Public.

Fix crash when closing tab with an open http auth sheet. Parts of patch by mdm@chromium.org, taken from http://codereview.chromium.org/196104 BUG=19427, 21111, 21304 (not sure about last one) TEST=Open a page with an http auth sheet, open another tab, close tab with the open sheet -- should not crash. Also check that opening a tab with an open sheet, then hitting back, forward, reload still works and doesn't crash. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=26105

Created: 11 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+10 lines, -5 lines)			Patch
	M	chrome/browser/login_prompt_mac.mm	View		3 chunks	+10 lines, -5 lines	0 comments	Download

Total messages: 2 (0 generated)

LG