Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(89)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1940923002: bluetooth: Add JS error messages for unimplemented features (Closed)

Created:
4 years, 7 months ago by François Beaufort
Modified:
4 years, 7 months ago
CC:
chromium-reviews, blink-reviews, haraken, scheib+watch_chromium.org, ortuno+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

bluetooth: Add JS error messages for unimplemented features BUG=607822 Committed: https://crrev.com/4ae4c0730e8984a7e18a0b2e170deec765b1a600 Cr-Commit-Position: refs/heads/master@{#391487}

Patch Set 1 #

Total comments: 1

Patch Set 2 : #

Patch Set 3 : Fix webkit tests #

Patch Set 4 : Rebase #

Patch Set 5 : #

Patch Set 6 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+127 lines, -0 lines) Patch
M third_party/WebKit/LayoutTests/TestExpectations View 1 2 3 4 5 1 chunk +73 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/modules/bluetooth/BluetoothRemoteGATTCharacteristic.cpp View 1 5 chunks +30 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/modules/bluetooth/BluetoothRemoteGATTServer.cpp View 2 chunks +8 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/modules/bluetooth/BluetoothRemoteGATTService.cpp View 3 chunks +16 lines, -0 lines 0 comments Download

Messages

Total messages: 27 (14 generated)
François Beaufort
Hello Vince, Can you have a look at this patch?
4 years, 7 months ago (2016-05-02 14:35:26 UTC) #2
scheib
LGTM with: https://codereview.chromium.org/1940923002/diff/1/third_party/WebKit/Source/modules/bluetooth/BluetoothRemoteGATTCharacteristic.cpp File third_party/WebKit/Source/modules/bluetooth/BluetoothRemoteGATTCharacteristic.cpp (right): https://codereview.chromium.org/1940923002/diff/1/third_party/WebKit/Source/modules/bluetooth/BluetoothRemoteGATTCharacteristic.cpp#newcode227 third_party/WebKit/Source/modules/bluetooth/BluetoothRemoteGATTCharacteristic.cpp:227: #if OS(MACOSX) Merge these instead of duplicating ...
4 years, 7 months ago (2016-05-02 17:12:28 UTC) #3
François Beaufort
On 2016/05/02 17:12:28, scheib wrote: > LGTM with: > > https://codereview.chromium.org/1940923002/diff/1/third_party/WebKit/Source/modules/bluetooth/BluetoothRemoteGATTCharacteristic.cpp > File > third_party/WebKit/Source/modules/bluetooth/BluetoothRemoteGATTCharacteristic.cpp ...
4 years, 7 months ago (2016-05-02 18:24:22 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1940923002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1940923002/20001
4 years, 7 months ago (2016-05-02 19:42:57 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/220870)
4 years, 7 months ago (2016-05-02 21:25:50 UTC) #9
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1940923002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1940923002/40001
4 years, 7 months ago (2016-05-03 07:57:52 UTC) #11
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1940923002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1940923002/60001
4 years, 7 months ago (2016-05-03 09:05:14 UTC) #14
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 7 months ago (2016-05-03 10:50:43 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1940923002/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1940923002/80001
4 years, 7 months ago (2016-05-04 09:39:49 UTC) #19
commit-bot: I haz the power
Try jobs failed on following builders: ios-device-gn on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-gn/builds/539) ios-simulator on tryserver.chromium.mac (JOB_FAILED, ...
4 years, 7 months ago (2016-05-04 09:41:55 UTC) #21
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1940923002/100001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1940923002/100001
4 years, 7 months ago (2016-05-04 10:02:37 UTC) #24
commit-bot: I haz the power
Committed patchset #6 (id:100001)
4 years, 7 months ago (2016-05-04 13:06:22 UTC) #25
commit-bot: I haz the power
4 years, 7 months ago (2016-05-04 13:08:44 UTC) #27
Message was sent while issue was closed. 
Patchset 6 (id:??) landed as
https://crrev.com/4ae4c0730e8984a7e18a0b2e170deec765b1a600
Cr-Commit-Position: refs/heads/master@{#391487}

Powered by Google App Engine
This is Rietveld 408576698