Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(135)

Issue 1940913002: [interpreter] Remove SharedFunctionInfo::IsInterpreted. (Closed)

Created:
4 years, 7 months ago by Michael Starzinger
Modified:
4 years, 7 months ago
Reviewers:
Yang
CC:
v8-reviews_googlegroups.com, Yang
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[interpreter] Remove SharedFunctionInfo::IsInterpreted. The predicate in question was a workaround for when the compilation pipeline still kept bytecode and baseline code on the same shared function info. It is not longer needed. In the long run we want a predicate which can determine the exact tier for each function. R=yangguo@chromium.org Committed: https://crrev.com/30f6dfb7aaed78f43d2a92b5724e6255e5fbfac6 Cr-Commit-Position: refs/heads/master@{#36007}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -16 lines) Patch
M src/debug/debug.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M src/factory.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M src/objects.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/objects-inl.h View 2 chunks +1 line, -11 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
Michael Starzinger
4 years, 7 months ago (2016-05-02 14:44:20 UTC) #3
Yang
LGTM!
4 years, 7 months ago (2016-05-03 19:52:13 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1940913002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1940913002/1
4 years, 7 months ago (2016-05-04 08:05:42 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-04 08:31:50 UTC) #8
commit-bot: I haz the power
4 years, 7 months ago (2016-05-04 08:32:18 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/30f6dfb7aaed78f43d2a92b5724e6255e5fbfac6
Cr-Commit-Position: refs/heads/master@{#36007}

Powered by Google App Engine
This is Rietveld 408576698