Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1940903002:
Update libjpeg-turbo to 1.4.90 (Closed)
DescriptionUpdate libjpeg-turbo to 1.4.90
Google3, Chrome, and Android are considering updates. Let's start
testing Skia on the newest version.
https://critique.corp.google.com/#review/116667446
https://codereview.chromium.org/1934113002
https://buganizer.corp.google.com/u/0/issues/28268702
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1940903002
Committed: https://skia.googlesource.com/skia/+/3994c161ec5a2b83e8f6bab4d9c469eec2668d92
Committed: https://skia.googlesource.com/skia/+/b917e04d513fc5bc9ceb101f45a0d66a945a3017
Patch Set 1 : #Patch Set 2 : Include clang fix #Messages
Total messages: 21 (11 generated)
Description was changed from ========== Update libjpeg-turbo to 1.4.90 Google3, Chrome, and Android are considering updates. Let's start testing Skia on the newest version. https://critique.corp.google.com/#review/116667446 https://codereview.chromium.org/1934113002 https://buganizer.corp.google.com/u/0/issues/28268702 BUG=skia: ========== to ========== Update libjpeg-turbo to 1.4.90 Google3, Chrome, and Android are considering updates. Let's start testing Skia on the newest version. https://critique.corp.google.com/#review/116667446 https://codereview.chromium.org/1934113002 https://buganizer.corp.google.com/u/0/issues/28268702 BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is... ==========
Patchset #1 (id:1) has been deleted
The CQ bit was checked by msarett@google.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1940903002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1940903002/20001
msarett@google.com changed reviewers: + djsollen@google.com, scroggo@google.com
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
lgtm
The CQ bit was checked by msarett@google.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1940903002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1940903002/20001
Message was sent while issue was closed.
Description was changed from ========== Update libjpeg-turbo to 1.4.90 Google3, Chrome, and Android are considering updates. Let's start testing Skia on the newest version. https://critique.corp.google.com/#review/116667446 https://codereview.chromium.org/1934113002 https://buganizer.corp.google.com/u/0/issues/28268702 BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is... ========== to ========== Update libjpeg-turbo to 1.4.90 Google3, Chrome, and Android are considering updates. Let's start testing Skia on the newest version. https://critique.corp.google.com/#review/116667446 https://codereview.chromium.org/1934113002 https://buganizer.corp.google.com/u/0/issues/28268702 BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is... Committed: https://skia.googlesource.com/skia/+/3994c161ec5a2b83e8f6bab4d9c469eec2668d92 ==========
Message was sent while issue was closed.
Committed patchset #1 (id:20001) as https://skia.googlesource.com/skia/+/3994c161ec5a2b83e8f6bab4d9c469eec2668d92
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:20001) has been created in https://codereview.chromium.org/1937143002/ by msarett@google.com. The reason for reverting is: Clang wants "strbeq" and gcc wants "streqb". Uggh. https://build.chromium.org/p/client.skia.compile/builders/Build-Mac-Clang-Arm....
Message was sent while issue was closed.
Description was changed from ========== Update libjpeg-turbo to 1.4.90 Google3, Chrome, and Android are considering updates. Let's start testing Skia on the newest version. https://critique.corp.google.com/#review/116667446 https://codereview.chromium.org/1934113002 https://buganizer.corp.google.com/u/0/issues/28268702 BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is... Committed: https://skia.googlesource.com/skia/+/3994c161ec5a2b83e8f6bab4d9c469eec2668d92 ========== to ========== Update libjpeg-turbo to 1.4.90 Google3, Chrome, and Android are considering updates. Let's start testing Skia on the newest version. https://critique.corp.google.com/#review/116667446 https://codereview.chromium.org/1934113002 https://buganizer.corp.google.com/u/0/issues/28268702 BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is... Committed: https://skia.googlesource.com/skia/+/3994c161ec5a2b83e8f6bab4d9c469eec2668d92 ==========
Created a pull request to fix this in upstream: https://github.com/libjpeg-turbo/libjpeg-turbo/pull/75
The CQ bit was checked by msarett@google.com
The patchset sent to the CQ was uploaded after l-g-t-m from scroggo@google.com Link to the patchset: https://codereview.chromium.org/1940903002/#ps40001 (title: "Include clang fix")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1940903002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1940903002/40001
Message was sent while issue was closed.
Description was changed from ========== Update libjpeg-turbo to 1.4.90 Google3, Chrome, and Android are considering updates. Let's start testing Skia on the newest version. https://critique.corp.google.com/#review/116667446 https://codereview.chromium.org/1934113002 https://buganizer.corp.google.com/u/0/issues/28268702 BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is... Committed: https://skia.googlesource.com/skia/+/3994c161ec5a2b83e8f6bab4d9c469eec2668d92 ========== to ========== Update libjpeg-turbo to 1.4.90 Google3, Chrome, and Android are considering updates. Let's start testing Skia on the newest version. https://critique.corp.google.com/#review/116667446 https://codereview.chromium.org/1934113002 https://buganizer.corp.google.com/u/0/issues/28268702 BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is... Committed: https://skia.googlesource.com/skia/+/3994c161ec5a2b83e8f6bab4d9c469eec2668d92 Committed: https://skia.googlesource.com/skia/+/b917e04d513fc5bc9ceb101f45a0d66a945a3017 ==========
Message was sent while issue was closed.
Committed patchset #2 (id:40001) as https://skia.googlesource.com/skia/+/b917e04d513fc5bc9ceb101f45a0d66a945a3017 |
