Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(45)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1940853002: Add support for timeouts when using AdbPrecompilationCommand (Closed)

Created:
4 years, 7 months ago by kustermann
Modified:
4 years, 7 months ago
Reviewers:
Bill Hesse
CC:
reviews_dartlang.org, Florian Schneider, rmacnak
Base URL:
https://github.com/dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Add support for timeouts when using AdbPrecompilationCommand R=whesse@google.com Committed: https://github.com/dart-lang/sdk/commit/abfea75f1e2be3709bb4ece30dc70de7e7561dd7

Patch Set 1 #

Patch Set 2 : #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+46 lines, -18 lines) Patch
M tools/testing/dart/android.dart View 1 6 chunks +38 lines, -13 lines 2 comments Download
M tools/testing/dart/test_runner.dart View 5 chunks +8 lines, -5 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
kustermann
4 years, 7 months ago (2016-05-02 11:33:58 UTC) #2
Bill Hesse
lgtm https://codereview.chromium.org/1940853002/diff/20001/tools/testing/dart/android.dart File tools/testing/dart/android.dart (right): https://codereview.chromium.org/1940853002/diff/20001/tools/testing/dart/android.dart#newcode47 tools/testing/dart/android.dart:47: [String stdin = "", Duration timeout]) { Should ...
4 years, 7 months ago (2016-05-02 11:54:17 UTC) #3
kustermann
Thanks. https://codereview.chromium.org/1940853002/diff/20001/tools/testing/dart/android.dart File tools/testing/dart/android.dart (right): https://codereview.chromium.org/1940853002/diff/20001/tools/testing/dart/android.dart#newcode47 tools/testing/dart/android.dart:47: [String stdin = "", Duration timeout]) { On ...
4 years, 7 months ago (2016-05-02 11:59:40 UTC) #4
kustermann
4 years, 7 months ago (2016-05-02 12:00:24 UTC) #6
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) manually as
abfea75f1e2be3709bb4ece30dc70de7e7561dd7 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698