Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(61)

Issue 1940843003: [Findit] Use PubSub built-in authentication for push endpoint. (Closed)

Created:
4 years, 7 months ago by stgao
Modified:
4 years, 7 months ago
CC:
chromium-reviews, infra-reviews+infra_chromium.org, jchinlee, mmandlis, inferno
Base URL:
https://chromium.googlesource.com/infra/infra.git@master
Target Ref:
refs/heads/master
Project:
infra
Visibility:
Public.

Description

[Findit] Use PubSub built-in authentication for push endpoint. After b/25788912, subscription in the same project as the push endpoint could bypass the authentication as shown in this CL. The authentication approach is described in https://cloud.google.com/pubsub/prereqs. This approach is verified through dummy apps on both appspot and googleplex. That means Fracas could also do push delivery instead of pull. BUG=600460 Committed: https://chromium.googlesource.com/infra/infra/+/24b1aae2d3e97b2fc14deae85b73691535157aae

Patch Set 1 #

Patch Set 2 : fix nit. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -35 lines) Patch
M appengine/findit/crash-frontend.yaml View 1 chunk +6 lines, -0 lines 0 comments Download
M appengine/findit/crash/test/crash_testcase.py View 1 1 chunk +0 lines, -1 line 0 comments Download
M appengine/findit/handlers/crash/fracas_crash.py View 3 chunks +10 lines, -17 lines 0 comments Download
M appengine/findit/handlers/crash/test/fracas_crash_test.py View 3 chunks +4 lines, -15 lines 0 comments Download
M appengine/findit/main.py View 1 chunk +1 line, -1 line 0 comments Download
M appengine/findit/model/crash/crash_config.py View 1 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 8 (4 generated)
stgao
ptal
4 years, 7 months ago (2016-05-03 00:48:07 UTC) #3
Martin Barbella
lgtm
4 years, 7 months ago (2016-05-03 05:22:19 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1940843003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1940843003/20001
4 years, 7 months ago (2016-05-03 05:48:22 UTC) #6
commit-bot: I haz the power
4 years, 7 months ago (2016-05-03 05:52:18 UTC) #8
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/infra/infra/+/24b1aae2d3e97b2fc14deae85b736...

Powered by Google App Engine
This is Rietveld 408576698