components/ntp_snippets/ntp_snippets_fetcher.cc - Issue 1940843002: [NTP Snippets] Add unit tests for NTPSnippetsFetcher

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/ntp_snippets/ntp_snippets_fetcher.cc

Issue 1940843002: [NTP Snippets] Add unit tests for NTPSnippetsFetcher (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Nits Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« components/ntp_snippets/BUILD.gn ('K') | « components/ntp_snippets/BUILD.gn ('k') | components/ntp_snippets/ntp_snippets_fetcher_unittest.cc » ('j') | components/ntp_snippets/ntp_snippets_fetcher_unittest.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/ntp_snippets/ntp_snippets_fetcher.cc

diff --git a/components/ntp_snippets/ntp_snippets_fetcher.cc b/components/ntp_snippets/ntp_snippets_fetcher.cc

index 2cb82135958e12b116cb883a50fef15634f8b8c3..7fe3d94b0e54b22c86e052357ff1bf1e2a1f0f48 100644

--- a/components/ntp_snippets/ntp_snippets_fetcher.cc

+++ b/components/ntp_snippets/ntp_snippets_fetcher.cc

@@ -86,7 +86,6 @@ NTPSnippetsFetcher::AddCallback(const SnippetsAvailableCallback& callback) {

void NTPSnippetsFetcher::FetchSnippets(const std::set<std::string>& hosts,

int count) {

- // TODO(treib): What to do if there's already a pending request?

Marc Treib 2016/05/02 11:12:00 Right now any pending request will just get implic

mastiz 2016/05/02 12:34:28 Done.

const std::string& key = is_stable_channel_

? google_apis::GetAPIKey()

: google_apis::GetNonStableAPIKey();