Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5)

Issue 1940793002: LayoutTests: adapt inspector debug step test to V8's interpreter. (Closed)

Created:
4 years, 7 months ago by Yang
Modified:
4 years, 7 months ago
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, sergeyv+blink_chromium.org, kozyatinskiy+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

LayoutTests: adapt inspector debug step test to V8's interpreter. When debugging using V8's interpreter, there are slight differences at return statements that directly returns the value of the previous statement. This fixes the test case to work regardless of the difference. R=machenbach@chromium.org, rmcilroy@chromium.org BUG=chromium:595646 Committed: https://crrev.com/94271b31605e73c7111bdc7049c111277e0b575a Cr-Commit-Position: refs/heads/master@{#390904}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -10 lines) Patch
M third_party/WebKit/LayoutTests/inspector/sources/debugger-step/debugger-step-through-promises.html View 2 chunks +2 lines, -5 lines 0 comments Download
M third_party/WebKit/LayoutTests/inspector/sources/debugger-step/debugger-step-through-promises-expected.txt View 1 chunk +1 line, -5 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
Yang
4 years, 7 months ago (2016-05-02 07:05:31 UTC) #1
Michael Achenbach
lgtm
4 years, 7 months ago (2016-05-02 07:07:10 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1940793002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1940793002/1
4 years, 7 months ago (2016-05-02 07:22:13 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-02 08:23:41 UTC) #7
commit-bot: I haz the power
4 years, 7 months ago (2016-05-02 08:25:18 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/94271b31605e73c7111bdc7049c111277e0b575a
Cr-Commit-Position: refs/heads/master@{#390904}

Powered by Google App Engine
This is Rietveld 408576698