third_party/WebKit/Source/modules/fetch/ReadableStreamDataConsumerHandleTest.cpp - Issue 1940763002: Use Persistent to retain pointers on unittests

Unified Diff: third_party/WebKit/Source/modules/fetch/ReadableStreamDataConsumerHandleTest.cpp

Issue 1940763002: Use Persistent to retain pointers on unittests (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: third_party/WebKit/Source/modules/fetch/ReadableStreamDataConsumerHandleTest.cpp

diff --git a/third_party/WebKit/Source/modules/fetch/ReadableStreamDataConsumerHandleTest.cpp b/third_party/WebKit/Source/modules/fetch/ReadableStreamDataConsumerHandleTest.cpp

index 4cbe6e9f66d54a8f5d8a8fafb959c3015e736065..fd891485b447dd19989bd7b993afecfc5a7b7613 100644

--- a/third_party/WebKit/Source/modules/fetch/ReadableStreamDataConsumerHandleTest.cpp

+++ b/third_party/WebKit/Source/modules/fetch/ReadableStreamDataConsumerHandleTest.cpp

@@ -103,7 +103,7 @@ TEST_F(ReadableStreamDataConsumerHandleTest, Create)

ASSERT_FALSE(stream.isEmpty());

OwnPtr<ReadableStreamDataConsumerHandle> handle = createHandle(stream);

ASSERT_TRUE(handle);

- MockClient* client = MockClient::create();

+ Persistent<MockClient> client = MockClient::create();

Checkpoint checkpoint;

InSequence s;

@@ -126,7 +126,7 @@ TEST_F(ReadableStreamDataConsumerHandleTest, EmptyStream)

ASSERT_FALSE(stream.isEmpty());

OwnPtr<ReadableStreamDataConsumerHandle> handle = createHandle(stream);

ASSERT_TRUE(handle);

- MockClient* client = MockClient::create();

+ Persistent<MockClient> client = MockClient::create();

Checkpoint checkpoint;

InSequence s;

@@ -157,7 +157,7 @@ TEST_F(ReadableStreamDataConsumerHandleTest, ErroredStream)

ASSERT_FALSE(stream.isEmpty());

OwnPtr<ReadableStreamDataConsumerHandle> handle = createHandle(stream);

ASSERT_TRUE(handle);

- MockClient* client = MockClient::create();

+ Persistent<MockClient> client = MockClient::create();

Checkpoint checkpoint;

InSequence s;

@@ -194,7 +194,7 @@ TEST_F(ReadableStreamDataConsumerHandleTest, Read)

ASSERT_FALSE(stream.isEmpty());

OwnPtr<ReadableStreamDataConsumerHandle> handle = createHandle(stream);

ASSERT_TRUE(handle);

- MockClient* client = MockClient::create();

+ Persistent<MockClient> client = MockClient::create();

Checkpoint checkpoint;

InSequence s;

@@ -262,7 +262,7 @@ TEST_F(ReadableStreamDataConsumerHandleTest, TwoPhaseRead)

ASSERT_FALSE(stream.isEmpty());

OwnPtr<ReadableStreamDataConsumerHandle> handle = createHandle(stream);

ASSERT_TRUE(handle);

- MockClient* client = MockClient::create();

+ Persistent<MockClient> client = MockClient::create();

Checkpoint checkpoint;

InSequence s;

@@ -339,7 +339,7 @@ TEST_F(ReadableStreamDataConsumerHandleTest, EnqueueUndefined)

ASSERT_FALSE(stream.isEmpty());

OwnPtr<ReadableStreamDataConsumerHandle> handle = createHandle(stream);

ASSERT_TRUE(handle);

- MockClient* client = MockClient::create();

+ Persistent<MockClient> client = MockClient::create();

Checkpoint checkpoint;

InSequence s;

@@ -374,7 +374,7 @@ TEST_F(ReadableStreamDataConsumerHandleTest, EnqueueNull)

ASSERT_FALSE(stream.isEmpty());

OwnPtr<ReadableStreamDataConsumerHandle> handle = createHandle(stream);

ASSERT_TRUE(handle);

- MockClient* client = MockClient::create();

+ Persistent<MockClient> client = MockClient::create();

Checkpoint checkpoint;

InSequence s;

@@ -409,7 +409,7 @@ TEST_F(ReadableStreamDataConsumerHandleTest, EnqueueString)

ASSERT_FALSE(stream.isEmpty());

OwnPtr<ReadableStreamDataConsumerHandle> handle = createHandle(stream);

ASSERT_TRUE(handle);

- MockClient* client = MockClient::create();

+ Persistent<MockClient> client = MockClient::create();

Checkpoint checkpoint;

InSequence s;

« no previous file with comments | « no previous file | no next file » | no next file with comments »