Issue 194074: Reorganize repaint tests into more accurate bugs, rebaseline one....

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 194074: Reorganize repaint tests into more accurate bugs, rebaseline one.... (Closed)

Created:
11 years, 3 months ago by dglazkov

Modified:
9 years, 6 months ago

Reviewers:
Julie Parent

CC:
chromium-reviews_googlegroups.com, darin (slow to review), pam+watch_chromium.org

Base URL:
svn://chrome-svn.corp.google.com/chrome/trunk/src/

Visibility:
Public.

Description

Reorganize repaint tests into more accurate bugs, rebaseline one. R=jparent BUG=8630 BUG=21386 BUG=18772 BUG=21510 TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=25930

Patch Set 1 #

Total comments: 1

Created: 11 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+30 lines, -33 lines)			Patch
M	webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/replaced/width100percent-textarea-expected.checksum	View	1 chunk	+1 line, -1 line	0 comments	Download
M	webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/replaced/width100percent-textarea-expected.png	View	Binary file		0 comments	Download
M	webkit/tools/layout_tests/test_expectations.txt	View	2 chunks	+29 lines, -32 lines	1 comment	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Julie Parent

11 years, 3 months ago (2009-09-10 21:32:45 UTC) #2

LGTM

http://codereview.chromium.org/194074/diff/1/2
File webkit/tools/layout_tests/test_expectations.txt (right):

http://codereview.chromium.org/194074/diff/1/2#newcode1506
Line 1506: // Linux checksum computation produces results, differnt from Windows
or upstream.
type-o

Expand Messages | Collapse Messages