Identify service worker version at main resource load time (BlinkSide)

public/web/WebServiceWorkerContextClient.h

 /*
  * Copyright (C) 2013 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 17 matching lines @@
  * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
  */
 
 #ifndef WebServiceWorkerContextClient_h
 #define WebServiceWorkerContextClient_h
 
 #include "WebWorkerPermissionClientProxy.h"
 
 namespace blink {
 
+class WebDataSource;
 class WebString;
 class WebServiceWorkerContextProxy;
 class WebServiceWorkerResponse;
+class WebURLRequest;
+class WebURLResponse;
+
+// This interface is implemented by the client and is only called on the main thread.
+// FIXME: put this in a seperate .h

[michaeln, 2014/03/14 01:01:02]

should be in another file, if we like this change i'll do that next and update
gyps and such

[kinuko, 2014/03/14 11:47:17]

Yes I think this change makes sense

+class WebServiceWorkerNetworkProvider {
+public:
+    virtual ~WebServiceWorkerNetworkProvider() { }
+
+    // A request is about to be sent out, and the client may modify it. Request
+    // is writable, and changes to the URL, for example, will change the request
+    // made. If this request is the result of a redirect, then redirectResponse
+    // will be non-null and contain the response that triggered the redirect.

[kinuko, 2014/03/14 11:47:17]

Is this comment from WebFrameClient? May give impression that we do a lot in its
implementation.

We don't use redirectResponse at least, if we won't use it in a future too could
we drop redirectResponse param (and the comment 'If this request is the...')?

[michaeln, 2014/03/15 01:22:39]

Done, removed the redirectResponse param and fixed the comment.

+    virtual void willSendRequest(blink::WebDataSource*, blink::WebURLRequest&, const blink::WebURLResponse& redirectResponse) { }
+};
 
 // This interface is implemented by the client. It is suppoed to be created
 // on the main thread and then passed on to the worker thread to be owned
 // by a newly created WorkerGlobalScope. All methods of this class, except
-// for workerContextFailedToStart(), are called on the worker thread.
+// for createServiceWorkerNetworkProvider() and workerContextFailedToStart(),
+// are called on the worker thread.
 // FIXME: Split this into EmbeddedWorkerContextClient and
 // ServiceWorkerScriptContextClient when we decide to use EmbeddedWorker
 // framework for other implementation (like SharedWorker).
 class WebServiceWorkerContextClient {
 public:
     virtual ~WebServiceWorkerContextClient() { }
 
     // A new WorkerGlobalScope is created and started to run on the
     // worker thread.
     // This also gives back a proxy to the client to talk to the
@@ skipping 21 matching lines @@
     // ServiceWorker specific method. Called after InstallEvent (dispatched
     // via WebServiceWorkerContextProxy) is handled by the ServiceWorker's
     // script context.
     virtual void didHandleInstallEvent(int installEventID) { }
 
     // ServiceWorker specific methods. Called after FetchEvent is handled by the
     // ServiceWorker's script context. When no response is provided, the browser
     // should fallback to native fetch.
     virtual void didHandleFetchEvent(int fetchEventID) { }
     virtual void didHandleFetchEvent(int fetchEventID, const WebServiceWorkerResponse& response) { }
+
+    // Ownership of the returned object is transferred to the caller.
+    virtual WebServiceWorkerNetworkProvider* createServiceWorkerNetworkProvider(blink::WebDataSource*) { return 0; }
 };
 
 } // namespace blink
 
 #endif // WebWorkerContextClient_h