pkg/analyzer/lib/src/dart/scanner/reader.dart - Issue 1940703002: Remove an unnecessary invocation of toString

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pkg/analyzer/lib/src/dart/scanner/reader.dart

Issue 1940703002: Remove an unnecessary invocation of toString (Closed) Base URL: https://github.com/dart-lang/sdk.git@master

Patch Set: Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: pkg/analyzer/lib/src/dart/scanner/reader.dart

diff --git a/pkg/analyzer/lib/src/dart/scanner/reader.dart b/pkg/analyzer/lib/src/dart/scanner/reader.dart

index 7382fa16627c2124ba8af05aeac5b3e29095bc47..81f506e09483a188e35d58a9be806e7578ee7879 100644

--- a/pkg/analyzer/lib/src/dart/scanner/reader.dart

+++ b/pkg/analyzer/lib/src/dart/scanner/reader.dart

@@ -143,7 +143,7 @@ class CharSequenceReader implements CharacterReader {

@override

String getString(int start, int endDelta) =>

- _sequence.substring(start, _charOffset + endDelta).toString();

+ _sequence.substring(start, _charOffset + endDelta);

@override

int peek() {

« no previous file with comments | « no previous file | no next file » | no next file with comments »