Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(38)

Issue 1940693002: Revert of Stop using deprecated hash_map in vtune-jit.cc. (Closed)

Created:
4 years, 7 months ago by Benedikt Meurer
Modified:
4 years, 7 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of Stop using deprecated hash_map in vtune-jit.cc. (patchset #1 id:1 of https://codereview.chromium.org/1924403002/ ) Reason for revert: Breaks vtune-jit build, see https://build.chromium.org/p/client.v8/builders/V8%20Linux%20-%20vtunejit/builds/10670 Original issue's description: > Stop using deprecated hash_map in vtune-jit.cc. > > Fixes https://github.com/nodejs/node/issues/6422. TBR=jochen@chromium.org,info@bnoordhuis.nl,ben@strongloop.com # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Committed: https://crrev.com/987bd9ccc70ec1302321de88191c69e618f14085 Cr-Commit-Position: refs/heads/master@{#35917}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -3 lines) Patch
M src/third_party/vtune/vtune-jit.cc View 2 chunks +22 lines, -3 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
Benedikt Meurer
Created Revert of Stop using deprecated hash_map in vtune-jit.cc.
4 years, 7 months ago (2016-04-30 18:24:45 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1940693002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1940693002/1
4 years, 7 months ago (2016-04-30 18:24:51 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-04-30 18:25:06 UTC) #3
commit-bot: I haz the power
4 years, 7 months ago (2016-05-01 22:04:11 UTC) #5
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/987bd9ccc70ec1302321de88191c69e618f14085
Cr-Commit-Position: refs/heads/master@{#35917}

Powered by Google App Engine
This is Rietveld 408576698