Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(46)

Issue 1940633002: Rename gfx::Display/Screen to display::Display/Screen in headless (Closed)

Created:
4 years, 7 months ago by oshima
Modified:
4 years, 7 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Rename gfx::Display/Screen to display::Display/Screen in headless BUG=597761 Committed: https://crrev.com/fa4fba016b77391c41b1e3baee2e3a9cd35ae5a1 Cr-Commit-Position: refs/heads/master@{#391214}

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+38 lines, -34 lines) Patch
M headless/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M headless/DEPS View 1 chunk +1 line, -0 lines 0 comments Download
M headless/lib/browser/headless_browser_main_parts.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M headless/lib/browser/headless_screen.h View 3 chunks +17 lines, -15 lines 0 comments Download
M headless/lib/browser/headless_screen.cc View 4 chunks +17 lines, -17 lines 0 comments Download

Messages

Total messages: 19 (10 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1940633002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1940633002/1
4 years, 7 months ago (2016-04-29 23:06:03 UTC) #2
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/175607)
4 years, 7 months ago (2016-04-29 23:13:56 UTC) #4
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1940633002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1940633002/20001
4 years, 7 months ago (2016-04-29 23:20:47 UTC) #6
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 7 months ago (2016-04-30 00:13:02 UTC) #11
oshima
hi, I'm sending to both of you because I'm not sure who will be available ...
4 years, 7 months ago (2016-04-30 00:14:54 UTC) #12
alex clarke (OOO till 29th)
lgtm
4 years, 7 months ago (2016-05-03 09:54:05 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1940633002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1940633002/20001
4 years, 7 months ago (2016-05-03 12:04:11 UTC) #15
commit-bot: I haz the power
Committed patchset #1 (id:20001)
4 years, 7 months ago (2016-05-03 12:57:03 UTC) #17
commit-bot: I haz the power
4 years, 7 months ago (2016-05-03 12:57:58 UTC) #19
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/fa4fba016b77391c41b1e3baee2e3a9cd35ae5a1
Cr-Commit-Position: refs/heads/master@{#391214}

Powered by Google App Engine
This is Rietveld 408576698