Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(190)

Issue 1940623002: [Blob] Added error reporting metrics to invalid message errors. (Closed)

Created:
4 years, 7 months ago by dmurph
Modified:
4 years, 7 months ago
Reviewers:
kinuko, Mark P
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@2704
Target Ref:
refs/pending/branch-heads/2704
Project:
chromium
Visibility:
Public.

Description

[Blob] Added error reporting metrics to invalid message errors. This helps us get to the bottom of where the invalid blob refcount and url calls are. It's unclear whether these are new or if they've always occurred, as we used to ignore these messages. R=kinuko@chromium.org, mpearson@chromium.org BUG=602443, 607698 Review URL: https://codereview.chromium.org/1893293006 Cr-Commit-Position: refs/heads/master@{#388626} (cherry picked from commit a00379794f50019c7047c83e537803b7ba2b11ea) Committed: https://chromium.googlesource.com/chromium/src/+/e0440e2b94ca72b49ce5a2bc45f814033b092d1f

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+42 lines, -0 lines) Patch
M content/browser/blob_storage/blob_dispatcher_host.cc View 6 chunks +19 lines, -0 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 2 chunks +23 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
dmurph
4 years, 7 months ago (2016-04-29 21:27:13 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
e0440e2b94ca72b49ce5a2bc45f814033b092d1f.

Powered by Google App Engine
This is Rietveld 408576698