Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(30)

Issue 1940613002: Fix race in SkTypeface_FreeType::onCountGlyphs. (Closed)

Created:
4 years, 7 months ago by bungeman-skia
Modified:
4 years, 7 months ago
Reviewers:
mtklein
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Fix race in SkTypeface_FreeType::onCountGlyphs. Found by TSAN. This makes the operation slightly slower, but it is not on any user's hot path. BUG=skia:5238 Committed: https://skia.googlesource.com/skia/+/572f879b6163e1a4fb790a7f63401a6cf0ade1d2

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -11 lines) Patch
M src/ports/SkFontHost_FreeType.cpp View 1 chunk +3 lines, -8 lines 0 comments Download
M src/ports/SkFontHost_FreeType_common.h View 2 chunks +0 lines, -3 lines 0 comments Download

Messages

Total messages: 14 (8 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1940613002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1940613002/1
4 years, 7 months ago (2016-04-29 21:22:35 UTC) #4
bungeman-skia
4 years, 7 months ago (2016-04-29 21:23:59 UTC) #6
mtklein
lgtm
4 years, 7 months ago (2016-04-29 21:29:15 UTC) #8
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 7 months ago (2016-04-29 21:44:11 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1940613002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1940613002/1
4 years, 7 months ago (2016-04-29 22:04:07 UTC) #12
commit-bot: I haz the power
4 years, 7 months ago (2016-04-29 22:05:07 UTC) #14
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/572f879b6163e1a4fb790a7f63401a6cf0ade1d2

Powered by Google App Engine
This is Rietveld 408576698