Utility for bootstrapping a local gerrit instance.

Utility for bootstrapping a local gerrit instance.

BUG=
R=cmp@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=211865

[cmp, 2013-07-16 21:54:22]

lgtm with changes

https://codereview.chromium.org/19406002/diff/1/testing_support/gerrit-init.sh
File testing_support/gerrit-init.sh (right):

https://codereview.chromium.org/19406002/diff/1/testing_support/gerrit-init.s...
testing_support/gerrit-init.sh:2: 
remove this empty line

https://codereview.chromium.org/19406002/diff/1/testing_support/gerrit-init.s...
testing_support/gerrit-init.sh:19: registered_on=$(date '+%Y-%m-%d
%H:%M:%S.000%:::z')
alphabetically order lines 13-19

https://codereview.chromium.org/19406002/diff/1/testing_support/gerrit-init.s...
testing_support/gerrit-init.sh:21: root=$(dirname "$0")
this variable is not used, delete it?

https://codereview.chromium.org/19406002/diff/1/testing_support/gerrit-init.s...
testing_support/gerrit-init.sh:23:
url='https://www.googleapis.com/storage/v1beta2/b/gerrit-releases/o?projection=noAcl'
before line 23, insert a comment that says something like "Determine the
name/version of a valid Gerrit .war file we can download."

https://codereview.chromium.org/19406002/diff/1/testing_support/gerrit-init.s...
testing_support/gerrit-init.sh:24: curl -s $url | python <(cat <<EOF
can you add some flags here that cause curl to be very strict about checking
https + certs for www.googleapis.com ?

https://codereview.chromium.org/19406002/diff/1/testing_support/gerrit-init.s...
testing_support/gerrit-init.sh:25: import json
before line 25, insert a comment that says "Take a list of JSON dicts and
translate them into a set of candidate Java .WAR filenames."  You should also
add something like "Input: ... <example of relevant part of input>" and "Output:
...".

https://codereview.chromium.org/19406002/diff/1/testing_support/gerrit-init.s...
testing_support/gerrit-init.sh:53: net_sum=$(echo -n $md5 | base64 -d | od -tx1
| head -1 | cut -d ' ' -f 2- | sed 's/ //g')
wrap to be less than 80 chars

[szager1, 2013-07-16 22:23:31]

PTAL, let me know if the new curl parameters are sufficient.

https://codereview.chromium.org/19406002/diff/1/testing_support/gerrit-init.sh
File testing_support/gerrit-init.sh (right):

https://codereview.chromium.org/19406002/diff/1/testing_support/gerrit-init.s...
testing_support/gerrit-init.sh:2: 
On 2013/07/16 21:54:22, cmp wrote:
> remove this empty line

Done.

https://codereview.chromium.org/19406002/diff/1/testing_support/gerrit-init.s...
testing_support/gerrit-init.sh:19: registered_on=$(date '+%Y-%m-%d
%H:%M:%S.000%:::z')
On 2013/07/16 21:54:22, cmp wrote:
> alphabetically order lines 13-19

Done.

https://codereview.chromium.org/19406002/diff/1/testing_support/gerrit-init.s...
testing_support/gerrit-init.sh:21: root=$(dirname "$0")
On 2013/07/16 21:54:22, cmp wrote:
> this variable is not used, delete it?

Done.

https://codereview.chromium.org/19406002/diff/1/testing_support/gerrit-init.s...
testing_support/gerrit-init.sh:23:
url='https://www.googleapis.com/storage/v1beta2/b/gerrit-releases/o?projection=noAcl'
On 2013/07/16 21:54:22, cmp wrote:
> before line 23, insert a comment that says something like "Determine the
> name/version of a valid Gerrit .war file we can download."

Done.

https://codereview.chromium.org/19406002/diff/1/testing_support/gerrit-init.s...
testing_support/gerrit-init.sh:24: curl -s $url | python <(cat <<EOF
On 2013/07/16 21:54:22, cmp wrote:
> can you add some flags here that cause curl to be very strict about checking
> https + certs for http://www.googleapis.com ?

Added --ssl-reqd.  Is there something else you had in mind for checking the
cert?

https://codereview.chromium.org/19406002/diff/1/testing_support/gerrit-init.s...
testing_support/gerrit-init.sh:25: import json
On 2013/07/16 21:54:22, cmp wrote:
> before line 25, insert a comment that says "Take a list of JSON dicts and
> translate them into a set of candidate Java .WAR filenames."  You should also
> add something like "Input: ... <example of relevant part of input>" and
"Output:
> ...".

Done.

https://codereview.chromium.org/19406002/diff/1/testing_support/gerrit-init.s...
testing_support/gerrit-init.sh:53: net_sum=$(echo -n $md5 | base64 -d | od -tx1
| head -1 | cut -d ' ' -f 2- | sed 's/ //g')
On 2013/07/16 21:54:22, cmp wrote:
> wrap to be less than 80 chars

Done.

[cmp, 2013-07-16 22:34:18]

https://codereview.chromium.org/19406002/diff/1/testing_support/gerrit-init.sh
File testing_support/gerrit-init.sh (right):

https://codereview.chromium.org/19406002/diff/1/testing_support/gerrit-init.s...
testing_support/gerrit-init.sh:24: curl -s $url | python <(cat <<EOF
Good enough for me for now.  I assume that all of the standard SSL cert security
checks are on by default with SSL connections in place.

[cmp, 2013-07-16 22:37:16]

lgtm with these changes

https://codereview.chromium.org/19406002/diff/3002/testing_support/gerrit-ini...
File testing_support/gerrit-init.sh (right):

https://codereview.chromium.org/19406002/diff/3002/testing_support/gerrit-ini...
testing_support/gerrit-init.sh:2: # Copyright (c) 2013 The Chromium OS Authors.
All rights reserved.
This line should be "The Chromium Authors", AFAIK.

https://codereview.chromium.org/19406002/diff/3002/testing_support/gerrit-ini...
testing_support/gerrit-init.sh:9: rundir="$(mktemp -d)"
in other places in this file, $() is used without quotes, here it's used with
quotes.  i suggest you drop the quotes here.

https://codereview.chromium.org/19406002/diff/3002/testing_support/gerrit-ini...
testing_support/gerrit-init.sh:83: curl --ssl-reqd -s -o "./$name"
"https://gerrit-releases.storage.googleapis.com/$name"
wrap at 80 chars (newline after "./$name" \)

[szager1, 2013-07-16 22:44:05]

Committed patchset #6 manually as r211865.