Add two tests to ensure WebContents does not leak on prerender swap in

Add two tests to ensure WebContents does not leak on prerender swap in

The test with beforeunload handler is as planned: the event should be dispatched
and the webcontents should be deleted. The test relies on the possibility to
send out an async XHR, even though the results of it are never seen in the
renderer.

I noticed that in PrerenderManager::SwapInternal() with any of
{unload,beforeunload} handler is set, the
old_web_contents->NeedToFireBeforeUnload() returns true. The second test is to
check the path when false is returned.

BUG=600693
Committed: https://crrev.com/f4f74cd515b1f1fd16e9604d9a5cc9c4af1cf28d
Cr-Commit-Position: refs/heads/master@{#392313}

[pasko, 2016-05-03 17:13:39]

Description was changed from

==========
Add two tests to ensure WebContents does not leak on prerender swap in

The test with beforeunload handler is as planned: the event should be dispatched
and the webcontents should be deleted. The test relies on the possibility to
send out an async XHR, even though the results of it are never seen in the
renderer.

I noticed that in PrerenderManager::SwapInternal() with any of
{unload,beforeunload} handler is set, the
old_web_contents->NeedToFireBeforeUnload() returns true. The second test is to
check the path when false is returned.

BUG=600693
==========

to

==========
Add two tests to ensure WebContents does not leak on prerender swap in

The test with beforeunload handler is as planned: the event should be dispatched
and the webcontents should be deleted. The test relies on the possibility to
send out an async XHR, even though the results of it are never seen in the
renderer.

I noticed that in PrerenderManager::SwapInternal() with any of
{unload,beforeunload} handler is set, the
old_web_contents->NeedToFireBeforeUnload() returns true. The second test is to
check the path when false is returned.

BUG=600693
==========

[pasko, 2016-05-03 17:13:39]

pasko@chromium.org changed reviewers:
+ mmenke@chromium.org

[pasko, 2016-05-03 17:13:52]

mmenke: PTaL

[mmenke, 2016-05-04 17:54:32]

LGTM, thanks for adding these tests!

https://codereview.chromium.org/1940363002/diff/1/chrome/browser/prerender/pr...
File chrome/browser/prerender/prerender_browsertest.cc (right):

https://codereview.chromium.org/1940363002/diff/1/chrome/browser/prerender/pr...
chrome/browser/prerender/prerender_browsertest.cc:3099: // WebContents would not
leak.
nit:  would - does or will

https://codereview.chromium.org/1940363002/diff/1/chrome/browser/prerender/pr...
chrome/browser/prerender/prerender_browsertest.cc:3130: // prerendered page is
swapped in. Also checks that its WebContents of the
nit: its -> the

[pasko, 2016-05-09 13:35:00]

thank you for review, landing..

apologies for slow response, that's due to a 4 day weekend

https://codereview.chromium.org/1940363002/diff/1/chrome/browser/prerender/pr...
File chrome/browser/prerender/prerender_browsertest.cc (right):

https://codereview.chromium.org/1940363002/diff/1/chrome/browser/prerender/pr...
chrome/browser/prerender/prerender_browsertest.cc:3099: // WebContents would not
leak.
On 2016/05/04 17:54:32, mmenke wrote:
> nit:  would - does or will

Done.

https://codereview.chromium.org/1940363002/diff/1/chrome/browser/prerender/pr...
chrome/browser/prerender/prerender_browsertest.cc:3130: // prerendered page is
swapped in. Also checks that its WebContents of the
On 2016/05/04 17:54:32, mmenke wrote:
> nit: its -> the

Done.

[pasko, 2016-05-09 13:35:21]

The CQ bit was checked by pasko@chromium.org

[pasko, 2016-05-09 13:35:22]

The patchset sent to the CQ was uploaded after l-g-t-m from mmenke@chromium.org
Link to the patchset: https://codereview.chromium.org/1940363002/#ps40001
(title: "nits in comments addressed")

[commit-bot: I haz the power, 2016-05-09 13:35:31]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1940363002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1940363002/40001

[commit-bot: I haz the power, 2016-05-09 14:42:47]

Description was changed from

==========
Add two tests to ensure WebContents does not leak on prerender swap in

The test with beforeunload handler is as planned: the event should be dispatched
and the webcontents should be deleted. The test relies on the possibility to
send out an async XHR, even though the results of it are never seen in the
renderer.

I noticed that in PrerenderManager::SwapInternal() with any of
{unload,beforeunload} handler is set, the
old_web_contents->NeedToFireBeforeUnload() returns true. The second test is to
check the path when false is returned.

BUG=600693
==========

to

==========
Add two tests to ensure WebContents does not leak on prerender swap in

The test with beforeunload handler is as planned: the event should be dispatched
and the webcontents should be deleted. The test relies on the possibility to
send out an async XHR, even though the results of it are never seen in the
renderer.

I noticed that in PrerenderManager::SwapInternal() with any of
{unload,beforeunload} handler is set, the
old_web_contents->NeedToFireBeforeUnload() returns true. The second test is to
check the path when false is returned.

BUG=600693
==========

[commit-bot: I haz the power, 2016-05-09 14:42:48]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-05-09 14:44:08]

Description was changed from

==========
Add two tests to ensure WebContents does not leak on prerender swap in

The test with beforeunload handler is as planned: the event should be dispatched
and the webcontents should be deleted. The test relies on the possibility to
send out an async XHR, even though the results of it are never seen in the
renderer.

I noticed that in PrerenderManager::SwapInternal() with any of
{unload,beforeunload} handler is set, the
old_web_contents->NeedToFireBeforeUnload() returns true. The second test is to
check the path when false is returned.

BUG=600693
==========

to

==========
Add two tests to ensure WebContents does not leak on prerender swap in

The test with beforeunload handler is as planned: the event should be dispatched
and the webcontents should be deleted. The test relies on the possibility to
send out an async XHR, even though the results of it are never seen in the
renderer.

I noticed that in PrerenderManager::SwapInternal() with any of
{unload,beforeunload} handler is set, the
old_web_contents->NeedToFireBeforeUnload() returns true. The second test is to
check the path when false is returned.

BUG=600693

Committed: https://crrev.com/f4f74cd515b1f1fd16e9604d9a5cc9c4af1cf28d
Cr-Commit-Position: refs/heads/master@{#392313}
==========

[commit-bot: I haz the power, 2016-05-09 14:44:09]

Patchset 3 (id:??) landed as
https://crrev.com/f4f74cd515b1f1fd16e9604d9a5cc9c4af1cf28d
Cr-Commit-Position: refs/heads/master@{#392313}