Make evaluateCommand reuse parent's result where needed....

chromium_step.py

 #!/usr/bin/python
 # Copyright (c) 2006-2008 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 """Subclasses of various slave command classes."""
 
 import copy
 import os
 
 from buildbot.steps import source
 from buildbot.process import buildstep
 from buildbot import slave
 from buildbot.steps import shell
+from buildbot.status import builder
 from log_parser import process_log
 
 
 class GClient(source.Source):
   """Check out a source tree using gclient."""
 
   name = 'gclient'
 
   def __init__(self, svnurl=None, rm_timeout=None, gclient_spec=None, env=None,
                **kwargs):
@@ skipping 93 matching lines @@
 
   def getText(self, cmd, results):
     text_list = self.describe(True)
     if self._result_text:
       self._result_text.insert(0, '<div class="BuildResultInfo">')
       self._result_text.append('</div>')
       text_list = text_list + self._result_text
     return text_list
 
   def evaluateCommand(self, cmd):
-    # If the log processor provides a facility to evaluate its performance,
-    # call it.
-    if self._log_processor and self._log_processor.evaluateCommand:
-      return self._log_processor.evaluateCommand(cmd)
+    result = None
 
-    # Otherwise, report success by default.
-    return builder.SUCCESS
+    # If the log processor provides an evaluateCommand method, call it.
+    if self._log_processor and 'evaluateCommand' in dir(self._log_processor):
+      result = self._log_processor.evaluateCommand(cmd)
+
+    if result is None or result is builder.SUCCESS:
+      # Report success of parent command.
+      result = shell.ShellCommand.evaluateCommand(self, cmd)
+
+    return result
 
   def _CreateReportLinkIfNeccessary(self):
     if self._log_processor.ReportLink():
       self.addURL('results', "%s" % self._log_processor.ReportLink())