Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(376)

Issue 1940283002: [serializer] cache ICs only as code stubs with key. (Closed)

Created:
4 years, 7 months ago by Yang
Modified:
4 years, 7 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[serializer] cache ICs only as code stubs with key. Some uninitialized ICs used to be implemented as builtins. This is apparently no longer the case. R=bmeurer@chromium.org, mvstanton@chromium.org Committed: https://crrev.com/b80bfbfe640963930939d7c64be74558c33d6ff3 Cr-Commit-Position: refs/heads/master@{#35980}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -36 lines) Patch
M src/snapshot/code-serializer.h View 1 chunk +0 lines, -2 lines 0 comments Download
M src/snapshot/code-serializer.cc View 2 chunks +1 line, -34 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
Yang
4 years, 7 months ago (2016-05-03 11:05:32 UTC) #1
mvstanton
LGTM. That's great! Toon did some additional cleanup a few weeks ago that followed through ...
4 years, 7 months ago (2016-05-03 11:27:32 UTC) #2
Yang
On 2016/05/03 11:27:32, mvstanton wrote: > LGTM. > That's great! > Toon did some additional ...
4 years, 7 months ago (2016-05-03 11:43:22 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1940283002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1940283002/1
4 years, 7 months ago (2016-05-03 12:22:34 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-03 13:07:19 UTC) #6
commit-bot: I haz the power
4 years, 7 months ago (2016-05-03 13:08:06 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b80bfbfe640963930939d7c64be74558c33d6ff3
Cr-Commit-Position: refs/heads/master@{#35980}

Powered by Google App Engine
This is Rietveld 408576698