third_party/WebKit/Source/core/frame/Window.idl - Issue 1940253002: Disallow certain blocking DOM calls during microtask execution.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/frame/Window.idl

Issue 1940253002: Disallow certain blocking DOM calls during microtask execution. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: updates Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/frame/UseCounter.h ('k') | third_party/WebKit/Source/core/xmlhttprequest/XMLHttpRequest.cpp » ('j') | third_party/WebKit/Source/platform/RuntimeEnabledFeatures.in » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/frame/Window.idl

diff --git a/third_party/WebKit/Source/core/frame/Window.idl b/third_party/WebKit/Source/core/frame/Window.idl

index e79a9b6724fdf7224df849f07c9c6292bd3f0183..76ccfa1790b01f8bbb446ec43c6d7876433aba40 100644

--- a/third_party/WebKit/Source/core/frame/Window.idl

+++ b/third_party/WebKit/Source/core/frame/Window.idl

@@ -72,11 +72,11 @@

[RuntimeEnabled=ApplicationCache, LogActivity=GetterOnly] readonly attribute ApplicationCache applicationCache;

// user prompts

- [Measure] void alert();

- [Measure] void alert(DOMString message);

- [Measure] boolean confirm(optional DOMString message = "");

- [Measure] DOMString? prompt(optional DOMString message = "", optional DOMString defaultValue = "");

- [Measure] void print();

+ [Measure, CallWith=ScriptState] void alert();

+ [Measure, CallWith=ScriptState] void alert(DOMString message);

+ [Measure, CallWith=ScriptState] boolean confirm(optional DOMString message = "");

+ [Measure, CallWith=ScriptState] DOMString? prompt(optional DOMString message = "", optional DOMString defaultValue = "");

+ [Measure, CallWith=ScriptState] void print();

[MeasureAs=UnprefixedRequestAnimationFrame] long requestAnimationFrame(FrameRequestCallback callback);

void cancelAnimationFrame(long handle);