third_party/WebKit/Source/core/frame/RemoteDOMWindow.cpp - Issue 1940253002: Disallow certain blocking DOM calls during microtask execution.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/frame/RemoteDOMWindow.cpp

Issue 1940253002: Disallow certain blocking DOM calls during microtask execution. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: updates Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/frame/RemoteDOMWindow.h ('k') | third_party/WebKit/Source/core/frame/UseCounter.h » ('j') | third_party/WebKit/Source/platform/RuntimeEnabledFeatures.in » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/frame/RemoteDOMWindow.cpp

diff --git a/third_party/WebKit/Source/core/frame/RemoteDOMWindow.cpp b/third_party/WebKit/Source/core/frame/RemoteDOMWindow.cpp

index 32c736d5791fa3da4cb0124ff7ba380462307f81..4a73330dd0ca15b12084560eeddf51b729f43e5f 100644

--- a/third_party/WebKit/Source/core/frame/RemoteDOMWindow.cpp

+++ b/third_party/WebKit/Source/core/frame/RemoteDOMWindow.cpp

@@ -208,7 +208,7 @@ void RemoteDOMWindow::blur()

// FIXME: Implement.

}

-void RemoteDOMWindow::print()

+void RemoteDOMWindow::print(ScriptState*)

{

ASSERT_NOT_REACHED();

}

@@ -218,18 +218,18 @@ void RemoteDOMWindow::stop()

// FIXME: Implement.

}

-void RemoteDOMWindow::alert(const String& message)

+void RemoteDOMWindow::alert(ScriptState*, const String& message)

{

ASSERT_NOT_REACHED();

}

-bool RemoteDOMWindow::confirm(const String& message)

+bool RemoteDOMWindow::confirm(ScriptState*, const String& message)

{

ASSERT_NOT_REACHED();

return false;

}

-String RemoteDOMWindow::prompt(const String& message, const String& defaultValue)

+String RemoteDOMWindow::prompt(ScriptState*, const String& message, const String& defaultValue)

{

ASSERT_NOT_REACHED();

return String();