third_party/WebKit/Source/core/frame/LocalDOMWindow.h - Issue 1940253002: Disallow certain blocking DOM calls during microtask execution.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/frame/LocalDOMWindow.h

Issue 1940253002: Disallow certain blocking DOM calls during microtask execution. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: updates Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/frame/Deprecation.cpp ('k') | third_party/WebKit/Source/core/frame/LocalDOMWindow.cpp » ('j') | third_party/WebKit/Source/platform/RuntimeEnabledFeatures.in » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/frame/LocalDOMWindow.h

diff --git a/third_party/WebKit/Source/core/frame/LocalDOMWindow.h b/third_party/WebKit/Source/core/frame/LocalDOMWindow.h

index 207635ef23de8f2f1f9bf402303b136e248ce6fc..9729689c0a597bcb268b0f9fb76fff8a9903caef 100644

--- a/third_party/WebKit/Source/core/frame/LocalDOMWindow.h

+++ b/third_party/WebKit/Source/core/frame/LocalDOMWindow.h

@@ -119,11 +119,11 @@ public:

int orientation() const override;

DOMSelection* getSelection() override;

void blur() override;

- void print() override;

+ void print(ScriptState*) override;

void stop() override;

- void alert(const String& message = String()) override;

- bool confirm(const String& message) override;

- String prompt(const String& message, const String& defaultValue) override;

+ void alert(ScriptState*, const String& message = String()) override;

+ bool confirm(ScriptState*, const String& message) override;

+ String prompt(ScriptState*, const String& message, const String& defaultValue) override;

bool find(const String&, bool caseSensitive, bool backwards, bool wrap, bool wholeWord, bool searchInFrames, bool showDialog) const override;

// FIXME: ScrollBehaviorSmooth is currently unsupported in VisualViewport.