Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(625)

Unified Diff: third_party/WebKit/Source/core/frame/Deprecation.cpp

Issue 1940253002: Disallow certain blocking DOM calls during microtask execution. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: updates Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/frame/Deprecation.cpp
diff --git a/third_party/WebKit/Source/core/frame/Deprecation.cpp b/third_party/WebKit/Source/core/frame/Deprecation.cpp
index 8bb12b520ce7ecf05683b7470b138fe258ad0dea..be699b5cebddfde194306dee8d31ef5a38bc0c44 100644
--- a/third_party/WebKit/Source/core/frame/Deprecation.cpp
+++ b/third_party/WebKit/Source/core/frame/Deprecation.cpp
@@ -373,6 +373,21 @@ String Deprecation::deprecationMessage(UseCounter::Feature feature)
case UseCounter::V8KeyboardEvent_KeyIdentifier_AttributeGetter:
return willBeRemoved("'KeyboardEvent.keyIdentifier'", 53, "5316065118650368");
+ case UseCounter::During_Microtask_Alert:
+ return willBeRemoved("Invoking 'alert()' during microtask execution", 53, "5647113010544640");
+
+ case UseCounter::During_Microtask_Confirm:
+ return willBeRemoved("Invoking 'confirm()' during microtask execution", 53, "5647113010544640");
+
+ case UseCounter::During_Microtask_Print:
+ return willBeRemoved("Invoking 'print()' during microtask execution", 53, "5647113010544640");
+
+ case UseCounter::During_Microtask_Prompt:
+ return willBeRemoved("Invoking 'prompt()' during microtask execution", 53, "5647113010544640");
+
+ case UseCounter::During_Microtask_SyncXHR:
+ return willBeRemoved("Invoking 'send()' on a sync XHR during microtask execution", 53, "5647113010544640");
+
// Features that aren't deprecated don't have a deprecation message.
default:
return String();
« no previous file with comments | « third_party/WebKit/Source/core/frame/DOMWindow.h ('k') | third_party/WebKit/Source/core/frame/LocalDOMWindow.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698