third_party/WebKit/Source/core/frame/DOMWindow.h - Issue 1940253002: Disallow certain blocking DOM calls during microtask execution.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/frame/DOMWindow.h

Issue 1940253002: Disallow certain blocking DOM calls during microtask execution. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: updates Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/bindings/core/v8/ExceptionState.h ('k') | third_party/WebKit/Source/core/frame/Deprecation.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/frame/DOMWindow.h

diff --git a/third_party/WebKit/Source/core/frame/DOMWindow.h b/third_party/WebKit/Source/core/frame/DOMWindow.h

index 6e7290d507f3b956ea4d3e285a942516849ab1a3..0c7bc5136e99e1ec69d85a4eab273277a68db0b5 100644

--- a/third_party/WebKit/Source/core/frame/DOMWindow.h

+++ b/third_party/WebKit/Source/core/frame/DOMWindow.h

@@ -35,6 +35,7 @@ class LocalDOMWindow;

class MediaQueryList;

class Navigator;

class Screen;

+class ScriptState;

class ScrollToOptions;

class SerializedScriptValue;

class Storage;

@@ -133,12 +134,12 @@ public:

void focus(ExecutionContext*);

virtual void blur() = 0;

void close(ExecutionContext*);

- virtual void print() = 0;

+ virtual void print(ScriptState*) = 0;

virtual void stop() = 0;

- virtual void alert(const String& message = String()) = 0;

- virtual bool confirm(const String& message) = 0;

- virtual String prompt(const String& message, const String& defaultValue) = 0;

+ virtual void alert(ScriptState*, const String& message = String()) = 0;

+ virtual bool confirm(ScriptState*, const String& message) = 0;

+ virtual String prompt(ScriptState*, const String& message, const String& defaultValue) = 0;

virtual bool find(const String&, bool caseSensitive, bool backwards, bool wrap, bool wholeWord, bool searchInFrames, bool showDialog) const = 0;