third_party/WebKit/LayoutTests/fast/dom/modal-dialogs-during-microtasks.html - Issue 1940253002: Disallow certain blocking DOM calls during microtask execution.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/LayoutTests/fast/dom/modal-dialogs-during-microtasks.html

Issue 1940253002: Disallow certain blocking DOM calls during microtask execution. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: updates Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: third_party/WebKit/LayoutTests/fast/dom/modal-dialogs-during-microtasks.html

diff --git a/third_party/WebKit/LayoutTests/fast/parser/iframe-sets-parent-to-javascript-url.html b/third_party/WebKit/LayoutTests/fast/dom/modal-dialogs-during-microtasks.html

similarity index 51%

copy from third_party/WebKit/LayoutTests/fast/parser/iframe-sets-parent-to-javascript-url.html

copy to third_party/WebKit/LayoutTests/fast/dom/modal-dialogs-during-microtasks.html

index 6846e28356879ab23aef32faa01f5941c65ef449..64c554500d5d8692b393f63390b3b97b2188080b 100644

--- a/third_party/WebKit/LayoutTests/fast/parser/iframe-sets-parent-to-javascript-url.html

+++ b/third_party/WebKit/LayoutTests/fast/dom/modal-dialogs-during-microtasks.html

@@ -1,13 +1,14 @@

+<!DOCTYPE html>

+<p>Passes if no alert() is displayed</p>

if (window.testRunner) {

testRunner.dumpAsText();

- testRunner.dumpChildFramesAsText();

testRunner.waitUntilDone();

}

-function done() {

+new Promise(function(res, rej) { res(); }).then(function() {

+ alert('this should not be shown');

if (window.testRunner)

testRunner.notifyDone();

+});

</script>

-<iframe src="resources/set-parent-to-javascript-url.html"></iframe>

« no previous file with comments | « no previous file | third_party/WebKit/LayoutTests/fast/dom/modal-dialogs-during-microtasks-expected.txt » ('j') | no next file with comments »