Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(178)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1940243002: [wasm] Fix bug with empty input to Wasm.instantiateModuleFromAsm() (Closed)

Created:
4 years, 7 months ago by titzer
Modified:
4 years, 7 months ago
Reviewers:
bradnelson, ahaas
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[wasm] Fix bug with empty input to Wasm.instantiateModuleFromAsm() R=ahaas@chromium.org,bradnelson@chromium.org BUG=chromium:605488 LOG=Y Committed: https://crrev.com/98c231299564bbc200bff8b5acbf5ebe643918a2 Cr-Commit-Position: refs/heads/master@{#35974}

Patch Set 1 #

Total comments: 1

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -3 lines) Patch
M src/wasm/wasm-js.cc View 1 chunk +5 lines, -0 lines 0 comments Download
A + test/mjsunit/regress/regress-605488.js View 1 1 chunk +4 lines, -3 lines 0 comments Download

Messages

Total messages: 9 (2 generated)
titzer
4 years, 7 months ago (2016-05-03 09:51:23 UTC) #1
ahaas
lgtm https://codereview.chromium.org/1940243002/diff/1/test/mjsunit/regress/regress-605488.js File test/mjsunit/regress/regress-605488.js (right): https://codereview.chromium.org/1940243002/diff/1/test/mjsunit/regress/regress-605488.js#newcode8 test/mjsunit/regress/regress-605488.js:8: Wasm.instantiateModuleFromAsm(""); Could you add an assert(false) after instantiateModuleFromAsm ...
4 years, 7 months ago (2016-05-03 09:58:04 UTC) #2
titzer
On 2016/05/03 09:58:04, ahaas wrote: > lgtm > > https://codereview.chromium.org/1940243002/diff/1/test/mjsunit/regress/regress-605488.js > File test/mjsunit/regress/regress-605488.js (right): > ...
4 years, 7 months ago (2016-05-03 10:49:11 UTC) #3
ahaas
lgtm
4 years, 7 months ago (2016-05-03 10:53:45 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1940243002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1940243002/20001
4 years, 7 months ago (2016-05-03 10:57:09 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 7 months ago (2016-05-03 11:14:08 UTC) #7
commit-bot: I haz the power
4 years, 7 months ago (2016-05-03 11:15:38 UTC) #9
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/98c231299564bbc200bff8b5acbf5ebe643918a2
Cr-Commit-Position: refs/heads/master@{#35974}

Powered by Google App Engine
This is Rietveld 408576698