Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(505)

Issue 1940213003: Fix handling of negative exit codes in test.dart on Android. (Closed)

Created:
4 years, 7 months ago by Florian Schneider
Modified:
4 years, 7 months ago
Reviewers:
kustermann
CC:
reviews_dartlang.org
Base URL:
https://github.com/dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Fix handling of negative exit codes in test.dart on Android. BUG=dartbug.com/26375 R=kustermann@google.com Committed: https://github.com/dart-lang/sdk/commit/174121435acec5968d191835186b080f5ee936fe

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -2 lines) Patch
M tests/language/language.status View 1 chunk +0 lines, -2 lines 0 comments Download
M tools/testing/dart/android.dart View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Florian Schneider
4 years, 7 months ago (2016-05-03 14:40:06 UTC) #2
kustermann
LGTM
4 years, 7 months ago (2016-05-03 14:44:33 UTC) #3
Florian Schneider
4 years, 7 months ago (2016-05-03 14:47:28 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
174121435acec5968d191835186b080f5ee936fe (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698