components/policy/core/common/policy_statistics_collector_unittest.cc - Issue 1940153002: Use std::unique_ptr to express ownership of base::Value in PolicyMap::Entry

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/policy/core/common/policy_statistics_collector_unittest.cc

Issue 1940153002: Use std::unique_ptr to express ownership of base::Value in PolicyMap::Entry (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: More fixes (partial Windows fix) Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« components/policy/core/common/policy_loader_win.cc ('K') | « components/policy/core/common/policy_service_impl_unittest.cc ('k') | components/policy/core/common/proxy_policy_provider_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/policy/core/common/policy_statistics_collector_unittest.cc

diff --git a/components/policy/core/common/policy_statistics_collector_unittest.cc b/components/policy/core/common/policy_statistics_collector_unittest.cc

index e316cc87aef428d7b84d8ef131095c21c92fab46..68a4398119b080b77dc786374fc0fac3aa2a287e 100644

--- a/components/policy/core/common/policy_statistics_collector_unittest.cc

+++ b/components/policy/core/common/policy_statistics_collector_unittest.cc

@@ -107,12 +107,9 @@ class PolicyStatisticsCollectorTest : public testing::Test {

}

void SetPolicy(const std::string& name) {

- policy_map_.Set(name,

- POLICY_LEVEL_MANDATORY,

- POLICY_SCOPE_USER,

- POLICY_SOURCE_CLOUD,

- new base::FundamentalValue(true),

- NULL);

+ policy_map_.Set(

+ name, POLICY_LEVEL_MANDATORY, POLICY_SCOPE_USER, POLICY_SOURCE_CLOUD,

+ base::WrapUnique(new base::FundamentalValue(true)), nullptr);

}

base::TimeDelta GetFirstDelay() const {