chrome/browser/policy/policy_startup_browsertest.cc - Issue 1940153002: Use std::unique_ptr to express ownership of base::Value in PolicyMap::Entry

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/policy/policy_startup_browsertest.cc

Issue 1940153002: Use std::unique_ptr to express ownership of base::Value in PolicyMap::Entry (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: More fixes (partial Windows fix) Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/policy/policy_prefs_browsertest.cc ('k') | chrome/browser/policy/profile_policy_connector_unittest.cc » ('j') | components/policy/core/browser/proxy_policy_handler_unittest.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/policy/policy_startup_browsertest.cc

diff --git a/chrome/browser/policy/policy_startup_browsertest.cc b/chrome/browser/policy/policy_startup_browsertest.cc

index 0f4d8e419353365dd7874fba8659f6c9da6ff004..80cde05c879313c2dfa2fb56d649cb192c3b03c6 100644

--- a/chrome/browser/policy/policy_startup_browsertest.cc

+++ b/chrome/browser/policy/policy_startup_browsertest.cc

@@ -7,6 +7,7 @@

#include "base/command_line.h"

#include "base/macros.h"

+#include "base/memory/ptr_util.h"

#include "chrome/common/chrome_result_codes.h"

#include "chrome/common/chrome_switches.h"

#include "chrome/test/base/in_process_browser_test.h"

@@ -32,11 +33,9 @@ class PolicyMakeDefaultBrowserTest : public InProcessBrowserTest {

policy::PolicyMap values;

values.Set(policy::key::kDefaultBrowserSettingEnabled,

- policy::POLICY_LEVEL_MANDATORY,

- policy::POLICY_SCOPE_MACHINE,

+ policy::POLICY_LEVEL_MANDATORY, policy::POLICY_SCOPE_MACHINE,

policy::POLICY_SOURCE_CLOUD,

- new base::FundamentalValue(false),

- NULL);

+ base::WrapUnique(new base::FundamentalValue(false)), nullptr);

provider_.UpdateChromePolicy(values);

}