chrome/browser/extensions/extension_management_test_util.cc - Issue 1940153002: Use std::unique_ptr to express ownership of base::Value in PolicyMap::Entry

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/extension_management_test_util.cc

Issue 1940153002: Use std::unique_ptr to express ownership of base::Value in PolicyMap::Entry (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: More fixes (partial Windows fix) Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/api/storage/policy_value_store_unittest.cc ('k') | chrome/browser/extensions/policy_handlers_unittest.cc » ('j') | components/policy/core/browser/proxy_policy_handler_unittest.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/extension_management_test_util.cc

diff --git a/chrome/browser/extensions/extension_management_test_util.cc b/chrome/browser/extensions/extension_management_test_util.cc

index 65b75adceb64d0b80640c153eb6006292338eb55..e974db4c6999feb646112704a23dc9812302c99c 100644

--- a/chrome/browser/extensions/extension_management_test_util.cc

+++ b/chrome/browser/extensions/extension_management_test_util.cc

@@ -261,11 +261,12 @@ ExtensionManagementPolicyUpdater::ExtensionManagementPolicyUpdater(

}

ExtensionManagementPolicyUpdater::~ExtensionManagementPolicyUpdater() {

- policies_->Get(policy::PolicyNamespace(policy::POLICY_DOMAIN_CHROME,

- std::string()))

+ policies_

+ ->Get(

+ policy::PolicyNamespace(policy::POLICY_DOMAIN_CHROME, std::string()))

.Set(policy::key::kExtensionSettings, policy::POLICY_LEVEL_MANDATORY,

- policy::POLICY_SCOPE_USER, policy::POLICY_SOURCE_CLOUD,

- TakePref().release(), nullptr);

+ policy::POLICY_SCOPE_USER, policy::POLICY_SOURCE_CLOUD, TakePref(),

+ nullptr);

provider_->UpdatePolicy(std::move(policies_));

}