chrome/browser/extensions/api/enterprise_device_attributes/enterprise_device_attributes_apitest.cc - Issue 1940153002: Use std::unique_ptr to express ownership of base::Value in PolicyMap::Entry

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/enterprise_device_attributes/enterprise_device_attributes_apitest.cc

Issue 1940153002: Use std::unique_ptr to express ownership of base::Value in PolicyMap::Entry (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: . Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/chromeos/policy/device_policy_decoder_chromeos.cc ('K') | « chrome/browser/extensions/api/certificate_provider/certificate_provider_apitest.cc ('k') | chrome/browser/extensions/api/enterprise_platform_keys/enterprise_platform_keys_apitest_nss.cc » ('j') | components/policy/core/common/policy_map.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/enterprise_device_attributes/enterprise_device_attributes_apitest.cc

diff --git a/chrome/browser/extensions/api/enterprise_device_attributes/enterprise_device_attributes_apitest.cc b/chrome/browser/extensions/api/enterprise_device_attributes/enterprise_device_attributes_apitest.cc

index d69fcbc14ebe6031233fc31fa1ff0ec8455f3e9b..eaa8c857caa595ccd217466774a4cedde9787033 100644

--- a/chrome/browser/extensions/api/enterprise_device_attributes/enterprise_device_attributes_apitest.cc

+++ b/chrome/browser/extensions/api/enterprise_device_attributes/enterprise_device_attributes_apitest.cc

@@ -147,7 +147,7 @@ class EnterpriseDeviceAttributesTest :

policy::PolicyMap policy;

policy.Set(policy::key::kExtensionInstallForcelist,

policy::POLICY_LEVEL_MANDATORY, policy::POLICY_SCOPE_MACHINE,

- policy::POLICY_SOURCE_CLOUD, forcelist.release(), nullptr);

+ policy::POLICY_SOURCE_CLOUD, std::move(forcelist), nullptr);

// Set the policy and wait until the extension is installed.

extensions::TestExtensionRegistryObserver observer(