chrome/browser/chromeos/policy/user_cloud_external_data_manager_browsertest.cc - Issue 1940153002: Use std::unique_ptr to express ownership of base::Value in PolicyMap::Entry

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/chromeos/policy/user_cloud_external_data_manager_browsertest.cc

Issue 1940153002: Use std::unique_ptr to express ownership of base::Value in PolicyMap::Entry (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: . Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/chromeos/policy/device_policy_decoder_chromeos.cc ('K') | « chrome/browser/chromeos/policy/network_configuration_updater_unittest.cc ('k') | chrome/browser/chromeos/policy/user_cloud_policy_manager_chromeos_unittest.cc » ('j') | components/policy/core/common/policy_map.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/chromeos/policy/user_cloud_external_data_manager_browsertest.cc

diff --git a/chrome/browser/chromeos/policy/user_cloud_external_data_manager_browsertest.cc b/chrome/browser/chromeos/policy/user_cloud_external_data_manager_browsertest.cc

index 6dbd8f798d7256b998979be7f7739d75a57b1e0d..cbb2be7e7506b96ee49b7e1dccabbe5ca95c5f69 100644

--- a/chrome/browser/chromeos/policy/user_cloud_external_data_manager_browsertest.cc

+++ b/chrome/browser/chromeos/policy/user_cloud_external_data_manager_browsertest.cc

@@ -84,7 +84,7 @@ IN_PROC_BROWSER_TEST_F(UserCloudExternalDataManagerTest, FetchExternalData) {

PolicyNamespace(POLICY_DOMAIN_CHROME, std::string()));

const PolicyMap::Entry* policy_entry = policies.Get(key::kHomepageLocation);

ASSERT_TRUE(policy_entry);

- EXPECT_TRUE(base::Value::Equals(metadata.get(), policy_entry->value));

+ EXPECT_TRUE(base::Value::Equals(metadata.get(), policy_entry->value.get()));

ASSERT_TRUE(policy_entry->external_data_fetcher);

base::RunLoop run_loop;