Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1899)

Unified Diff: chrome/browser/prefs/synced_pref_change_registrar_browsertest.cc

Issue 1940153002: Use std::unique_ptr to express ownership of base::Value in PolicyMap::Entry (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: another-fix Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/prefs/synced_pref_change_registrar_browsertest.cc
diff --git a/chrome/browser/prefs/synced_pref_change_registrar_browsertest.cc b/chrome/browser/prefs/synced_pref_change_registrar_browsertest.cc
index 7dedec07eaf6e422eb879944fa6d62ca1623af87..f7aa7c3961f950b617525af92452414f46e47783 100644
--- a/chrome/browser/prefs/synced_pref_change_registrar_browsertest.cc
+++ b/chrome/browser/prefs/synced_pref_change_registrar_browsertest.cc
@@ -6,6 +6,7 @@
#include <string>
#include "base/json/json_string_value_serializer.h"
+#include "base/memory/ptr_util.h"
#include "base/time/time.h"
#include "base/values.h"
#include "chrome/browser/prefs/pref_service_syncable_util.h"
@@ -179,12 +180,9 @@ IN_PROC_BROWSER_TEST_F(SyncedPrefChangeRegistrarTest,
base::Bind(&TestPrefChangeCallback, prefs(), &observer));
policy::PolicyMap policies;
- policies.Set(policy::key::kShowHomeButton,
- policy::POLICY_LEVEL_MANDATORY,
- policy::POLICY_SCOPE_USER,
- policy::POLICY_SOURCE_CLOUD,
- new base::FundamentalValue(true),
- NULL);
+ policies.Set(policy::key::kShowHomeButton, policy::POLICY_LEVEL_MANDATORY,
+ policy::POLICY_SCOPE_USER, policy::POLICY_SOURCE_CLOUD,
+ base::WrapUnique(new base::FundamentalValue(true)), nullptr);
UpdateChromePolicy(policies);
EXPECT_TRUE(prefs()->IsManagedPreference(prefs::kShowHomeButton));
@@ -201,12 +199,9 @@ IN_PROC_BROWSER_TEST_F(SyncedPrefChangeRegistrarTest,
base::Bind(&TestPrefChangeCallback, prefs(), &observer));
policy::PolicyMap policies;
- policies.Set(policy::key::kShowHomeButton,
- policy::POLICY_LEVEL_MANDATORY,
- policy::POLICY_SCOPE_USER,
- policy::POLICY_SOURCE_CLOUD,
- new base::FundamentalValue(true),
- NULL);
+ policies.Set(policy::key::kShowHomeButton, policy::POLICY_LEVEL_MANDATORY,
+ policy::POLICY_SCOPE_USER, policy::POLICY_SOURCE_CLOUD,
+ base::WrapUnique(new base::FundamentalValue(true)), nullptr);
UpdateChromePolicy(policies);
EXPECT_TRUE(prefs()->IsManagedPreference(prefs::kShowHomeButton));
« no previous file with comments | « chrome/browser/prefs/proxy_policy_unittest.cc ('k') | chrome/browser/profiles/incognito_mode_policy_handler_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698