Use std::unique_ptr to express ownership of base::Value in PolicyMap::Entry

components/policy/core/common/policy_bundle_unittest.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "components/policy/core/common/policy_bundle.h"
 
 #include <memory>
+#include <utility>
 
 #include "base/callback.h"
+#include "base/memory/ptr_util.h"
 #include "base/values.h"
 #include "components/policy/core/common/external_data_fetcher.h"
 #include "components/policy/core/common/policy_map.h"
 #include "components/policy/core/common/policy_types.h"
 #include "testing/gtest/include/gtest/gtest.h"
 
 namespace policy {
 
 namespace {
 
 const char kPolicyClashing0[] = "policy-clashing-0";
 const char kPolicyClashing1[] = "policy-clashing-1";
 const char kPolicy0[] = "policy-0";
 const char kPolicy1[] = "policy-1";
 const char kPolicy2[] = "policy-2";
 const char kExtension0[] = "extension-0";
 const char kExtension1[] = "extension-1";
 const char kExtension2[] = "extension-2";
 const char kExtension3[] = "extension-3";
 
 // Adds test policies to |policy|.
 void AddTestPolicies(PolicyMap* policy) {
-  policy->Set("mandatory-user",
-              POLICY_LEVEL_MANDATORY,
-              POLICY_SCOPE_USER,
+  policy->Set("mandatory-user", POLICY_LEVEL_MANDATORY, POLICY_SCOPE_USER,
               POLICY_SOURCE_CLOUD,
-              new base::FundamentalValue(123),
-              NULL);
-  policy->Set("mandatory-machine",
-              POLICY_LEVEL_MANDATORY,
-              POLICY_SCOPE_MACHINE,
+              base::WrapUnique(new base::FundamentalValue(123)), nullptr);
+  policy->Set("mandatory-machine", POLICY_LEVEL_MANDATORY, POLICY_SCOPE_MACHINE,
               POLICY_SOURCE_CLOUD,
-              new base::StringValue("omg"),
-              NULL);
-  policy->Set("recommended-user",
-              POLICY_LEVEL_RECOMMENDED,
-              POLICY_SCOPE_USER,
+              base::WrapUnique(new base::StringValue("omg")), nullptr);
+  policy->Set("recommended-user", POLICY_LEVEL_RECOMMENDED, POLICY_SCOPE_USER,
               POLICY_SOURCE_CLOUD,
-              new base::FundamentalValue(true),
-              NULL);
-  base::DictionaryValue* dict = new base::DictionaryValue();
+              base::WrapUnique(new base::FundamentalValue(true)), nullptr);
+  std::unique_ptr<base::DictionaryValue> dict(new base::DictionaryValue());
   dict->SetBoolean("false", false);
   dict->SetInteger("int", 456);
   dict->SetString("str", "bbq");
   policy->Set("recommended-machine", POLICY_LEVEL_RECOMMENDED,
-              POLICY_SCOPE_MACHINE, POLICY_SOURCE_CLOUD, dict, nullptr);
+              POLICY_SCOPE_MACHINE, POLICY_SOURCE_CLOUD, std::move(dict),
+              nullptr);
 }
 
 // Adds test policies to |policy| based on the parameters:
 // - kPolicyClashing0 mapped to |value|, user mandatory
 // - kPolicyClashing1 mapped to |value|, with |level| and |scope|
 // - |name| mapped to |value|, user mandatory
 void AddTestPoliciesWithParams(PolicyMap *policy,
                                const char* name,
                                int value,
                                PolicyLevel level,
                                PolicyScope scope) {
-  policy->Set(kPolicyClashing0,
-              POLICY_LEVEL_MANDATORY,
-              POLICY_SCOPE_USER,
+  policy->Set(kPolicyClashing0, POLICY_LEVEL_MANDATORY, POLICY_SCOPE_USER,
               POLICY_SOURCE_CLOUD,
-              new base::FundamentalValue(value),
-              NULL);
+              base::WrapUnique(new base::FundamentalValue(value)), nullptr);
   policy->Set(kPolicyClashing1, level, scope, POLICY_SOURCE_CLOUD,
-              new base::FundamentalValue(value), nullptr);
-  policy->Set(name,
-              POLICY_LEVEL_MANDATORY,
-              POLICY_SCOPE_USER,
+              base::WrapUnique(new base::FundamentalValue(value)), nullptr);
+  policy->Set(name, POLICY_LEVEL_MANDATORY, POLICY_SCOPE_USER,
               POLICY_SOURCE_CLOUD,
-              new base::FundamentalValue(value),
-              NULL);
+              base::WrapUnique(new base::FundamentalValue(value)), nullptr);
 }
 
 // Returns true if |bundle| is empty.
 bool IsEmpty(const PolicyBundle& bundle) {
   return bundle.begin() == bundle.end();
 }
 
 }  // namespace
 
 TEST(PolicyBundleTest, Get) {
@@ skipping 106 matching lines @@
   merged.MergeFrom(bundle2);
   PolicyBundle empty_bundle;
   merged.MergeFrom(empty_bundle);
 
   // chrome and kExtension3 policies are merged:
   // - kPolicyClashing0 comes from bundle0, which has the highest priority;
   // - kPolicyClashing1 comes from bundle1, which has the highest level/scope
   //   combination;
   // - kPolicyN are merged from each bundle.
   PolicyMap expected;
-  expected.Set(kPolicyClashing0,
-               POLICY_LEVEL_MANDATORY,
-               POLICY_SCOPE_USER,
+  expected.Set(kPolicyClashing0, POLICY_LEVEL_MANDATORY, POLICY_SCOPE_USER,
                POLICY_SOURCE_CLOUD,
-               new base::FundamentalValue(0),
-               NULL);
-  expected.Set(kPolicyClashing1,
-               POLICY_LEVEL_MANDATORY,
-               POLICY_SCOPE_MACHINE,
+               base::WrapUnique(new base::FundamentalValue(0)), nullptr);
+  expected.Set(kPolicyClashing1, POLICY_LEVEL_MANDATORY, POLICY_SCOPE_MACHINE,
                POLICY_SOURCE_CLOUD,
-               new base::FundamentalValue(1),
-               NULL);
-  expected.Set(kPolicy0,
-               POLICY_LEVEL_MANDATORY,
-               POLICY_SCOPE_USER,
+               base::WrapUnique(new base::FundamentalValue(1)), nullptr);
+  expected.Set(kPolicy0, POLICY_LEVEL_MANDATORY, POLICY_SCOPE_USER,
                POLICY_SOURCE_CLOUD,
-               new base::FundamentalValue(0),
-               NULL);
-  expected.Set(kPolicy1,
-               POLICY_LEVEL_MANDATORY,
-               POLICY_SCOPE_USER,
+               base::WrapUnique(new base::FundamentalValue(0)), nullptr);
+  expected.Set(kPolicy1, POLICY_LEVEL_MANDATORY, POLICY_SCOPE_USER,
                POLICY_SOURCE_CLOUD,
-               new base::FundamentalValue(1),
-               NULL);
-  expected.Set(kPolicy2,
-               POLICY_LEVEL_MANDATORY,
-               POLICY_SCOPE_USER,
+               base::WrapUnique(new base::FundamentalValue(1)), nullptr);
+  expected.Set(kPolicy2, POLICY_LEVEL_MANDATORY, POLICY_SCOPE_USER,
                POLICY_SOURCE_CLOUD,
-               new base::FundamentalValue(2),
-               NULL);
+               base::WrapUnique(new base::FundamentalValue(2)), nullptr);
   EXPECT_TRUE(merged.Get(PolicyNamespace(POLICY_DOMAIN_CHROME,
                                          std::string())).Equals(expected));
   EXPECT_TRUE(merged.Get(PolicyNamespace(POLICY_DOMAIN_EXTENSIONS,
                                          kExtension3)).Equals(expected));
   // extension0 comes only from bundle0.
   EXPECT_TRUE(merged.Get(PolicyNamespace(POLICY_DOMAIN_EXTENSIONS,
                                          kExtension0)).Equals(policy0));
   // extension1 comes only from bundle1.
   EXPECT_TRUE(merged.Get(PolicyNamespace(POLICY_DOMAIN_EXTENSIONS,
                                          kExtension1)).Equals(policy1));
@@ skipping 18 matching lines @@
       PolicyNamespace(POLICY_DOMAIN_EXTENSIONS, kExtension1)));
   EXPECT_FALSE(bundle.Equals(other));
   other.CopyFrom(bundle);
   EXPECT_TRUE(bundle.Equals(other));
   AddTestPolicies(&other.Get(
       PolicyNamespace(POLICY_DOMAIN_EXTENSIONS, kExtension2)));
   EXPECT_FALSE(bundle.Equals(other));
 
   other.CopyFrom(bundle);
   bundle.Get(PolicyNamespace(POLICY_DOMAIN_CHROME, std::string()))
-      .Set(kPolicy0,
-           POLICY_LEVEL_MANDATORY,
-           POLICY_SCOPE_USER,
+      .Set(kPolicy0, POLICY_LEVEL_MANDATORY, POLICY_SCOPE_USER,
            POLICY_SOURCE_CLOUD,
-           new base::FundamentalValue(123),
-           NULL);
+           base::WrapUnique(new base::FundamentalValue(123)), nullptr);
   EXPECT_FALSE(bundle.Equals(other));
   other.CopyFrom(bundle);
   EXPECT_TRUE(bundle.Equals(other));
   bundle.Get(PolicyNamespace(POLICY_DOMAIN_CHROME, std::string()))
-      .Set(kPolicy0,
-           POLICY_LEVEL_MANDATORY,
-           POLICY_SCOPE_MACHINE,
+      .Set(kPolicy0, POLICY_LEVEL_MANDATORY, POLICY_SCOPE_MACHINE,
            POLICY_SOURCE_CLOUD,
-           new base::FundamentalValue(123),
-           NULL);
+           base::WrapUnique(new base::FundamentalValue(123)), nullptr);
   EXPECT_FALSE(bundle.Equals(other));
 
   // Test non-const Get().
   bundle.Clear();
   other.Clear();
   PolicyMap& policy_map =
       bundle.Get(PolicyNamespace(POLICY_DOMAIN_CHROME, std::string()));
   EXPECT_TRUE(bundle.Equals(other));
-  policy_map.Set(kPolicy0,
-                 POLICY_LEVEL_MANDATORY,
-                 POLICY_SCOPE_USER,
+  policy_map.Set(kPolicy0, POLICY_LEVEL_MANDATORY, POLICY_SCOPE_USER,
                  POLICY_SOURCE_CLOUD,
-                 new base::FundamentalValue(123),
-                 NULL);
+                 base::WrapUnique(new base::FundamentalValue(123)), nullptr);
   EXPECT_FALSE(bundle.Equals(other));
 }
 
 }  // namespace policy