Use std::unique_ptr to express ownership of base::Value in PolicyMap::Entry

components/policy/core/common/cloud/cloud_policy_manager_unittest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "components/policy/core/common/cloud/cloud_policy_manager.h"
 
 #include <memory>
 
 #include "base/callback.h"
 #include "base/compiler_specific.h"
 #include "base/macros.h"
+#include "base/memory/ptr_util.h"
 #include "components/policy/core/common/cloud/cloud_policy_constants.h"
 #include "components/policy/core/common/cloud/mock_cloud_policy_client.h"
 #include "components/policy/core/common/cloud/mock_cloud_policy_store.h"
 #include "components/policy/core/common/cloud/policy_builder.h"
 #include "components/policy/core/common/configuration_policy_provider_test.h"
 #include "components/policy/core/common/external_data_fetcher.h"
 #include "components/policy/core/common/mock_configuration_policy_provider.h"
 #include "components/policy/core/common/policy_types.h"
 #include "components/policy/core/common/schema_registry.h"
 #include "testing/gmock/include/gmock/gmock.h"
@@ skipping 58 matching lines @@
       new CloudPolicyManager(dm_protocol::kChromeUserPolicyType, std::string(),
                              &store_, task_runner, task_runner, task_runner);
   Mock::VerifyAndClearExpectations(&store_);
   return provider;
 }
 
 void TestHarness::InstallEmptyPolicy() {}
 
 void TestHarness::InstallStringPolicy(const std::string& policy_name,
                                       const std::string& policy_value) {
-  store_.policy_map_.Set(policy_name,
-                         policy_level(),
-                         policy_scope(),
-                         POLICY_SOURCE_CLOUD,
-                         new base::StringValue(policy_value),
-                         nullptr);
+  store_.policy_map_.Set(
+      policy_name, policy_level(), policy_scope(), POLICY_SOURCE_CLOUD,
+      base::WrapUnique(new base::StringValue(policy_value)), nullptr);
 }
 
 void TestHarness::InstallIntegerPolicy(const std::string& policy_name,
                                        int policy_value) {
-  store_.policy_map_.Set(policy_name,
-                         policy_level(),
-                         policy_scope(),
-                         POLICY_SOURCE_CLOUD,
-                         new base::
-                         FundamentalValue(policy_value),
-                         nullptr);
+  store_.policy_map_.Set(
+      policy_name, policy_level(), policy_scope(), POLICY_SOURCE_CLOUD,
+      base::WrapUnique(new base::FundamentalValue(policy_value)), nullptr);
 }
 
 void TestHarness::InstallBooleanPolicy(const std::string& policy_name,
                                        bool policy_value) {
-  store_.policy_map_.Set(policy_name,
-                         policy_level(),
-                         policy_scope(),
-                         POLICY_SOURCE_CLOUD,
-                         new base::
-                         FundamentalValue(policy_value),
-                         nullptr);
+  store_.policy_map_.Set(
+      policy_name, policy_level(), policy_scope(), POLICY_SOURCE_CLOUD,
+      base::WrapUnique(new base::FundamentalValue(policy_value)), nullptr);
 }
 
 void TestHarness::InstallStringListPolicy(const std::string& policy_name,
                                           const base::ListValue* policy_value) {
-  store_.policy_map_.Set(policy_name,
-                         policy_level(),
-                         policy_scope(),
-                         POLICY_SOURCE_CLOUD,
-                         policy_value->DeepCopy(),
+  store_.policy_map_.Set(policy_name, policy_level(), policy_scope(),
+                         POLICY_SOURCE_CLOUD, policy_value->CreateDeepCopy(),
                          nullptr);
 }
 
 void TestHarness::InstallDictionaryPolicy(
     const std::string& policy_name,
     const base::DictionaryValue* policy_value) {
-  store_.policy_map_.Set(policy_name,
-                         policy_level(),
-                         policy_scope(),
-                         POLICY_SOURCE_CLOUD,
-                         policy_value->DeepCopy(),
+  store_.policy_map_.Set(policy_name, policy_level(), policy_scope(),
+                         POLICY_SOURCE_CLOUD, policy_value->CreateDeepCopy(),
                          nullptr);
 }
 
 // static
 PolicyProviderTestHarness* TestHarness::CreateMandatory() {
   return new TestHarness(POLICY_LEVEL_MANDATORY);
 }
 
 // static
 PolicyProviderTestHarness* TestHarness::CreateRecommended() {
@@ skipping 34 matching lines @@
   return arg.SerializePartialAsString() == proto.SerializePartialAsString();
 }
 
 class CloudPolicyManagerTest : public testing::Test {
  protected:
   CloudPolicyManagerTest()
       : policy_type_(dm_protocol::kChromeUserPolicyType) {}
 
   void SetUp() override {
     // Set up a policy map for testing.
-    policy_map_.Set("key",
-                    POLICY_LEVEL_MANDATORY,
-                    POLICY_SCOPE_USER,
+    policy_map_.Set("key", POLICY_LEVEL_MANDATORY, POLICY_SCOPE_USER,
                     POLICY_SOURCE_CLOUD,
-                    new base::StringValue("value"),
-                    nullptr);
+                    base::WrapUnique(new base::StringValue("value")), nullptr);
     expected_bundle_.Get(PolicyNamespace(POLICY_DOMAIN_CHROME, std::string()))
         .CopyFrom(policy_map_);
 
     policy_.payload().mutable_passwordmanagerenabled()->set_value(false);
     policy_.Build();
 
     EXPECT_CALL(store_, Load());
     manager_.reset(new TestCloudPolicyManager(&store_, loop_.task_runner()));
     manager_->Init(&schema_registry_);
     Mock::VerifyAndClearExpectations(&store_);
@@ skipping 159 matching lines @@
   store_.policy_.reset(new em::PolicyData(policy_.policy_data()));
   EXPECT_CALL(observer_, OnUpdatePolicy(manager_.get()));
   store_.NotifyStoreError();
   Mock::VerifyAndClearExpectations(&observer_);
 
   EXPECT_TRUE(manager_->IsInitializationComplete(POLICY_DOMAIN_CHROME));
 }
 
 }  // namespace
 }  // namespace policy