Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(687)

Side by Side Diff: chrome/browser/chromeos/extensions/device_local_account_external_policy_loader_unittest.cc

Issue 1940153002: Use std::unique_ptr to express ownership of base::Value in PolicyMap::Entry (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: another-fix Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/chromeos/extensions/device_local_account_external_polic y_loader.h" 5 #include "chrome/browser/chromeos/extensions/device_local_account_external_polic y_loader.h"
6 6
7 #include <string> 7 #include <string>
8 #include <utility>
8 9
9 #include "base/callback.h" 10 #include "base/callback.h"
10 #include "base/files/file_util.h" 11 #include "base/files/file_util.h"
11 #include "base/files/scoped_temp_dir.h" 12 #include "base/files/scoped_temp_dir.h"
12 #include "base/macros.h" 13 #include "base/macros.h"
13 #include "base/message_loop/message_loop.h" 14 #include "base/message_loop/message_loop.h"
14 #include "base/path_service.h" 15 #include "base/path_service.h"
15 #include "base/run_loop.h" 16 #include "base/run_loop.h"
16 #include "base/strings/stringprintf.h" 17 #include "base/strings/stringprintf.h"
17 #include "base/thread_task_runner_handle.h" 18 #include "base/thread_task_runner_handle.h"
(...skipping 158 matching lines...) Expand 10 before | Expand all | Expand 10 after
176 177
177 void DeviceLocalAccountExternalPolicyLoaderTest::SetForceInstallListPolicy() { 178 void DeviceLocalAccountExternalPolicyLoaderTest::SetForceInstallListPolicy() {
178 std::unique_ptr<base::ListValue> forcelist(new base::ListValue); 179 std::unique_ptr<base::ListValue> forcelist(new base::ListValue);
179 forcelist->AppendString("invalid"); 180 forcelist->AppendString("invalid");
180 forcelist->AppendString(base::StringPrintf( 181 forcelist->AppendString(base::StringPrintf(
181 "%s;%s", 182 "%s;%s",
182 kExtensionId, 183 kExtensionId,
183 extension_urls::GetWebstoreUpdateUrl().spec().c_str())); 184 extension_urls::GetWebstoreUpdateUrl().spec().c_str()));
184 store_.policy_map_.Set(policy::key::kExtensionInstallForcelist, 185 store_.policy_map_.Set(policy::key::kExtensionInstallForcelist,
185 policy::POLICY_LEVEL_MANDATORY, 186 policy::POLICY_LEVEL_MANDATORY,
186 policy::POLICY_SCOPE_USER, 187 policy::POLICY_SCOPE_USER, policy::POLICY_SOURCE_CLOUD,
187 policy::POLICY_SOURCE_CLOUD, 188 std::move(forcelist), nullptr);
188 forcelist.release(),
189 NULL);
190 store_.NotifyStoreLoaded(); 189 store_.NotifyStoreLoaded();
191 } 190 }
192 191
193 // Verifies that when the cache is not explicitly started, the loader does not 192 // Verifies that when the cache is not explicitly started, the loader does not
194 // serve any extensions, even if the force-install list policy is set or a load 193 // serve any extensions, even if the force-install list policy is set or a load
195 // is manually requested. 194 // is manually requested.
196 TEST_F(DeviceLocalAccountExternalPolicyLoaderTest, CacheNotStarted) { 195 TEST_F(DeviceLocalAccountExternalPolicyLoaderTest, CacheNotStarted) {
197 // Set the force-install list policy. 196 // Set the force-install list policy.
198 SetForceInstallListPolicy(); 197 SetForceInstallListPolicy();
199 198
(...skipping 113 matching lines...) Expand 10 before | Expand all | Expand 10 after
313 loader_->StopCache(shutdown_run_loop.QuitClosure()); 312 loader_->StopCache(shutdown_run_loop.QuitClosure());
314 VerifyAndResetVisitorCallExpectations(); 313 VerifyAndResetVisitorCallExpectations();
315 314
316 // Spin the loop until the cache shutdown callback is invoked. Verify that at 315 // Spin the loop until the cache shutdown callback is invoked. Verify that at
317 // that point, no further file I/O tasks are pending. 316 // that point, no further file I/O tasks are pending.
318 shutdown_run_loop.Run(); 317 shutdown_run_loop.Run();
319 EXPECT_TRUE(base::MessageLoop::current()->IsIdleForTesting()); 318 EXPECT_TRUE(base::MessageLoop::current()->IsIdleForTesting());
320 } 319 }
321 320
322 } // namespace chromeos 321 } // namespace chromeos
OLDNEW
« no previous file with comments | « chrome/browser/chromeos/arc/arc_policy_bridge_unittest.cc ('k') | chrome/browser/chromeos/login/saml/saml_browsertest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698