Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Issue 1940143002: X87: [turbofan] Run everything after representation selection concurrently. (Closed)

Created:
4 years, 7 months ago by zhengxing.li
Modified:
4 years, 7 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

X87: [turbofan] Run everything after representation selection concurrently. port d1b3d426ceae45e13ccf30cd4ac6e99e2bb8baf6 (r35918) original commit message: Further refactor the pipeline to even run the first scheduler (part of the effect control linearization) concurrently. This temporarily disables most of the write barrier elimination, but we will get back to that later. Drive-by-fix: Remove the dead code from ChangeLowering, and stack allocate the Typer in the pipeline. Also migrate the AllocateStub to a native code builtin, so that we have the code object + a handle to it available all the time. BUG= Committed: https://crrev.com/8d018a39e41b4cd3780eeb09cff26b49cc806bc5 Cr-Commit-Position: refs/heads/master@{#35961}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+39 lines, -7 lines) Patch
M src/x87/builtins-x87.cc View 1 chunk +38 lines, -0 lines 0 comments Download
M src/x87/interface-descriptors-x87.cc View 1 chunk +0 lines, -7 lines 0 comments Download
M src/x87/macro-assembler-x87.h View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
zhengxing.li
PTAL, thanks!
4 years, 7 months ago (2016-05-03 04:53:36 UTC) #2
Weiliang
lgtm
4 years, 7 months ago (2016-05-03 05:33:57 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1940143002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1940143002/1
4 years, 7 months ago (2016-05-03 05:34:56 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-03 05:56:38 UTC) #6
commit-bot: I haz the power
4 years, 7 months ago (2016-05-03 05:57:06 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/8d018a39e41b4cd3780eeb09cff26b49cc806bc5
Cr-Commit-Position: refs/heads/master@{#35961}

Powered by Google App Engine
This is Rietveld 408576698