Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(47)

Unified Diff: extensions/browser/value_store/value_store_change.cc

Issue 1940133002: Use std::unique_ptr to transfer base::Value ownership in extensions::ValueStoreChange (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: . Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: extensions/browser/value_store/value_store_change.cc
diff --git a/extensions/browser/value_store/value_store_change.cc b/extensions/browser/value_store/value_store_change.cc
index 3bbad592d06d092cad53ce99a93986fce2457b70..423eb065ade153f6519217e709a332f05832380e 100644
--- a/extensions/browser/value_store/value_store_change.cc
+++ b/extensions/browser/value_store/value_store_change.cc
@@ -4,8 +4,11 @@
#include "extensions/browser/value_store/value_store_change.h"
+#include <utility>
+
#include "base/json/json_writer.h"
#include "base/logging.h"
+#include "base/memory/ptr_util.h"
// static
std::string ValueStoreChange::ToJson(
@@ -27,9 +30,10 @@ std::string ValueStoreChange::ToJson(
return json;
}
-ValueStoreChange::ValueStoreChange(
- const std::string& key, base::Value* old_value, base::Value* new_value)
- : inner_(new Inner(key, old_value, new_value)) {}
+ValueStoreChange::ValueStoreChange(const std::string& key,
+ std::unique_ptr<base::Value> old_value,
+ std::unique_ptr<base::Value> new_value)
+ : inner_(new Inner(key, std::move(old_value), std::move(new_value))) {}
ValueStoreChange::ValueStoreChange(const ValueStoreChange& other) = default;
@@ -50,8 +54,11 @@ const base::Value* ValueStoreChange::new_value() const {
return inner_->new_value_.get();
}
-ValueStoreChange::Inner::Inner(
- const std::string& key, base::Value* old_value, base::Value* new_value)
- : key_(key), old_value_(old_value), new_value_(new_value) {}
+ValueStoreChange::Inner::Inner(const std::string& key,
+ std::unique_ptr<base::Value> old_value,
+ std::unique_ptr<base::Value> new_value)
+ : key_(key),
+ old_value_(std::move(old_value)),
+ new_value_(std::move(new_value)) {}
ValueStoreChange::Inner::~Inner() {}
« no previous file with comments | « extensions/browser/value_store/value_store_change.h ('k') | extensions/browser/value_store/value_store_change_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698