Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(421)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 194013003: [webcrypto] Remove support for SHA-224 (CL 1 or 3). (Closed)

Created:
6 years, 9 months ago by eroman
Modified:
6 years, 9 months ago
Reviewers:
abarth-chromium
CC:
blink-reviews, jamesr, dglazkov+blink, abarth-chromium
Visibility:
Public.

Description

[webcrypto] Remove support for SHA-224 (CL 1 or 3). Blink side of the change. This was removed by the spec: https://dvcs.w3.org/hg/webcrypto-api/rev/3f7df730b2c7 BUG=245025 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=168959

Patch Set 1 #

Patch Set 2 : Oops add changed test expectations! #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -21 lines) Patch
M LayoutTests/crypto/digest.html View 3 chunks +0 lines, -15 lines 0 comments Download
M LayoutTests/crypto/digest-expected.txt View 1 1 chunk +0 lines, -3 lines 0 comments Download
M Source/modules/crypto/NormalizeAlgorithm.cpp View 2 chunks +0 lines, -2 lines 0 comments Download
M public/platform/WebCryptoAlgorithm.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 13 (0 generated)
eroman
6 years, 9 months ago (2014-03-11 03:36:52 UTC) #1
abarth-chromium
lgtm
6 years, 9 months ago (2014-03-11 07:29:49 UTC) #2
eroman
The CQ bit was checked by eroman@chromium.org
6 years, 9 months ago (2014-03-11 17:31:06 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/eroman@chromium.org/194013003/1
6 years, 9 months ago (2014-03-11 17:31:11 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-11 18:06:12 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: mac_blink_rel
6 years, 9 months ago (2014-03-11 18:06:14 UTC) #6
eroman
The CQ bit was checked by eroman@chromium.org
6 years, 9 months ago (2014-03-11 19:08:26 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/eroman@chromium.org/194013003/20001
6 years, 9 months ago (2014-03-11 19:08:34 UTC) #8
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-11 20:01:45 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: linux_blink
6 years, 9 months ago (2014-03-11 20:01:46 UTC) #10
eroman
The CQ bit was checked by eroman@chromium.org
6 years, 9 months ago (2014-03-11 20:07:43 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/eroman@chromium.org/194013003/20001
6 years, 9 months ago (2014-03-11 20:08:03 UTC) #12
commit-bot: I haz the power
6 years, 9 months ago (2014-03-11 22:27:37 UTC) #13
Message was sent while issue was closed. 
Change committed as 168959

Powered by Google App Engine
This is Rietveld 408576698