Issue 19401003: Revert "WebCrypto: Add SHA-1 support to crypto.subtle.digest()."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 19401003: Revert "WebCrypto: Add SHA-1 support to crypto.subtle.digest()." (Closed)

Created:
7 years, 5 months ago by eroman

Modified:
7 years, 5 months ago

Reviewers:

CC:
blink-reviews, Nils Barth (inactive), jamesr, jsbell+bindings_chromium.org, eae+blinkwatch, tommyw+watchlist_chromium.org, abarth-chromium, marja+watch_chromium.org, dglazkov+blink, adamk+blink_chromium.org, haraken, Nate Chapin, jeez, do-not-use

Base URL:
svn://svn.chromium.org/blink/trunk

Visibility:
Public.

More Reviews

Description

Revert "WebCrypto: Add SHA-1 support to crypto.subtle.digest()." This reverts r154310 to see if it was responsible for layout test flake on buildbots. BUG=245025 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=154318

Patch Set 1 #

Created: 7 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+66 lines, -773 lines)			Patch
D	LayoutTests/crypto/digest.html	View	1 chunk	+0 lines, -192 lines	0 comments	Download
D	LayoutTests/crypto/digest-expected.txt	View	1 chunk	+0 lines, -38 lines	0 comments	Download
M	Source/bindings/v8/ScriptValue.h	View	1 chunk	+0 lines, -2 lines	0 comments	Download
M	Source/core/core.gypi	View	1 chunk	+0 lines, -1 line	0 comments	Download
D	Source/core/platform/chromium/support/WebArrayBuffer.cpp	View	1 chunk	+0 lines, -103 lines	0 comments	Download
M	Source/modules/crypto/CryptoOperation.h	View	2 chunks	+2 lines, -40 lines	0 comments	Download
M	Source/modules/crypto/CryptoOperation.cpp	View	2 chunks	+1 line, -109 lines	0 comments	Download
M	Source/modules/crypto/CryptoOperation.idl	View	1 chunk	+0 lines, -6 lines	0 comments	Download
M	Source/modules/crypto/NormalizeAlgorithm.cpp	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	Source/modules/crypto/SubtleCrypto.cpp	View	6 chunks	+6 lines, -63 lines	0 comments	Download
A +	Source/web/WebArrayBuffer.cpp	View	1 chunk	+1 line, -1 line	0 comments	Download
M	Source/web/WebBindings.cpp	View	2 chunks	+1 line, -1 line	0 comments	Download
M	Source/web/WebSocketImpl.cpp	View	2 chunks	+1 line, -1 line	0 comments	Download
M	Source/web/web.gypi	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	public/README	View	1 chunk	+0 lines, -2 lines	0 comments	Download
M	public/platform/Platform.h	View	4 chunks	+0 lines, -9 lines	0 comments	Download
D	public/platform/WebArrayBuffer.h	View	1 chunk	+0 lines, -82 lines	0 comments	Download
D	public/platform/WebCrypto.h	View	1 chunk	+0 lines, -119 lines	0 comments	Download
M	public/web/WebArrayBuffer.h	View	2 chunks	+53 lines, -3 lines	0 comments	Download

Messages

Total messages: 1 (0 generated)

Expand Messages | Collapse Messages

Message was sent while issue was closed.

Committed patchset #1 manually as r154318.

Expand Messages | Collapse Messages