Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(141)

Issue 1940073002: cc: Make property tree destructor and clear non-virtual. (Closed)

Created:
4 years, 7 months ago by jbroman
Modified:
4 years, 7 months ago
Reviewers:
ajuma
CC:
cc-bugs_chromium.org, chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

cc: Make property tree destructor and clear non-virtual. These are never invoked through a base class pointer, so there is no apparent need for virtual dispatch here. CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel Committed: https://crrev.com/de8272afe52ff8f21b792aebc892ae347e8a7b5b Cr-Commit-Position: refs/heads/master@{#391232}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -6 lines) Patch
M cc/trees/property_tree.h View 5 chunks +6 lines, -6 lines 0 comments Download

Messages

Total messages: 11 (5 generated)
jbroman
4 years, 7 months ago (2016-05-03 13:52:29 UTC) #4
ajuma
lgtm, thanks for cleaning this up.
4 years, 7 months ago (2016-05-03 14:08:23 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1940073002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1940073002/1
4 years, 7 months ago (2016-05-03 14:08:57 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-03 14:44:00 UTC) #8
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/de8272afe52ff8f21b792aebc892ae347e8a7b5b Cr-Commit-Position: refs/heads/master@{#391232}
4 years, 7 months ago (2016-05-03 14:45:29 UTC) #10
esprehn
4 years, 7 months ago (2016-05-04 02:54:04 UTC) #11
Message was sent while issue was closed.
If they're final the compiler will just do this for you, using virtual means you
get correctness when someone adds the call later. :)

Powered by Google App Engine
This is Rietveld 408576698