Breakpad about:crash crashing browser (oops)

base/mac_util.mm

 // Copyright (c) 2008 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/mac_util.h"
 
 #import <Cocoa/Cocoa.h>
 
 #include "base/file_path.h"
 #include "base/logging.h"
@@ skipping 26 matching lines @@
   FSCatalogInfo info;
   if (FSGetCatalogInfo(&fsref, kFSCatInfoNodeFlags, &info,
                        NULL, NULL, NULL) != noErr) {
     return false;
   }
 
   return info.nodeFlags & kFSNodeIsDirectoryMask;
 }
 
 bool IsBackgroundOnlyProcess() {
-  NSBundle* main_bundle = MainAppBundle();
-  NSDictionary* info_dictionary = [main_bundle infoDictionary];
+  // This function really does want to examine NSBundle's idea of the main
+  // bundle dictionary, and not the overriden MainAppBundle.  It needs to look
+  // at the actual running .app's Info.plist to access its LSUIElement
+  // property.
+  NSDictionary* info_dictionary = [[NSBundle mainBundle] infoDictionary];
   return [[info_dictionary objectForKey:@"LSUIElement"] boolValue] != NO;
 }
 
 // No threading worries since NSBundle isn't thread safe.
 static NSBundle* g_override_app_bundle = nil;
 
 NSBundle* MainAppBundle() {
   if (g_override_app_bundle)
     return g_override_app_bundle;
   return [NSBundle mainBundle];
@@ skipping 37 matching lines @@
   NSString* library_dir = [dirs objectAtIndex:0];
   const char* library_dir_path = [library_dir fileSystemRepresentation];
   if (!library_dir_path)
     return FilePath();
 
   return FilePath(library_dir_path);
 }
 
 
 }  // namespace mac_util