Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(227)

Issue 1940053002: [MD settings] hide side nav drawer at 900px (Closed)

Created:
4 years, 7 months ago by dschuyler
Modified:
4 years, 7 months ago
Reviewers:
Dan Beam
CC:
chromium-reviews, michaelpg+watch-md-settings_chromium.org, michaelpg+watch-md-ui_chromium.org, dbeam+watch-settings_chromium.org, stevenjb+watch-md-settings_chromium.org, arv+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[MD settings] hide side nav drawer at 900px This CL changes the threshold where the side nav drawer narrows (hide or shows) from 600px to 900px which makes the drawer hide just as the right edge starts to overlap the settings. BUG=60851 Committed: https://crrev.com/cb143831d77e14c4bcdcbf5afa2d1d3e3ae3cfb6 Cr-Commit-Position: refs/heads/master@{#391143}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M chrome/browser/resources/settings/settings_ui/settings_ui.html View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 8 (3 generated)
dschuyler
4 years, 7 months ago (2016-05-02 23:45:11 UTC) #2
Dan Beam
lgtm
4 years, 7 months ago (2016-05-02 23:45:47 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1940053002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1940053002/1
4 years, 7 months ago (2016-05-03 01:24:04 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-03 01:28:08 UTC) #6
commit-bot: I haz the power
4 years, 7 months ago (2016-05-03 01:29:34 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/cb143831d77e14c4bcdcbf5afa2d1d3e3ae3cfb6
Cr-Commit-Position: refs/heads/master@{#391143}

Powered by Google App Engine
This is Rietveld 408576698