Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(745)

Issue 1940033002: Use STL map for m_eventTargets. (Closed)

Created:
4 years, 7 months ago by Tom Sepez
Modified:
4 years, 7 months ago
Reviewers:
Lei Zhang
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@master
Target Ref:
refs/heads/master
Project:
pdfium
Visibility:
Public.

Description

Use STL map for m_eventTargets. Remove unused member and return value along the way. Committed: https://pdfium.googlesource.com/pdfium/+/877a547fdbd461e75c309c0f24135ba663027b81

Patch Set 1 #

Patch Set 2 : rename #

Patch Set 3 : Remove unused stuff. #

Patch Set 4 : Rebase, manual merge required. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+37 lines, -46 lines) Patch
M xfa/fwl/core/fwl_noteimp.h View 1 2 3 4 chunks +5 lines, -3 lines 0 comments Download
M xfa/fwl/core/fwl_noteimp.cpp View 1 2 3 4 chunks +32 lines, -43 lines 0 comments Download

Messages

Total messages: 13 (7 generated)
Tom Sepez
Lei, for review.
4 years, 7 months ago (2016-05-02 22:24:39 UTC) #2
Lei Zhang
lgtm
4 years, 7 months ago (2016-05-09 19:28:21 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1940033002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1940033002/40001
4 years, 7 months ago (2016-05-09 19:28:27 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: mac_no_v8 on master.tryserver.client.pdfium (JOB_FAILED, https://build.chromium.org/p/tryserver.client.pdfium/builders/mac_no_v8/builds/525)
4 years, 7 months ago (2016-05-09 19:38:17 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1940033002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1940033002/60001
4 years, 7 months ago (2016-05-11 17:48:01 UTC) #11
commit-bot: I haz the power
4 years, 7 months ago (2016-05-11 18:05:57 UTC) #13
Message was sent while issue was closed.
Committed patchset #4 (id:60001) as
https://pdfium.googlesource.com/pdfium/+/877a547fdbd461e75c309c0f24135ba66302...

Powered by Google App Engine
This is Rietveld 408576698