Issue 194002: Add external protocol dialog for Linux....

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 194002: Add external protocol dialog for Linux.... (Closed)

Created:
11 years, 3 months ago by Evan Stade

Modified:
9 years, 6 months ago

Reviewers:
Mike Mammarella

CC:
chromium-reviews_googlegroups.com, Ben Goodger (Google)

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Add external protocol dialog for Linux. This exposes a bug where \n in a string resource is rendered literally when it is displayed. I don't know at what point on Windows the '\' + 'n' is translated to a line return, I have filed crbug.com/20943 BUG=20731 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=25373

Patch Set 1 #

Patch Set 2 : typo fix #

Patch Set 3 : typo fix2 #

Patch Set 4 : '' #

Created: 11 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+182 lines, -80 lines)			Patch
M	chrome/browser/external_protocol_handler.h	View	1 2 3	4 chunks	+19 lines, -5 lines	0 comments	Download
M	chrome/browser/external_protocol_handler.cc	View	1 2 3	3 chunks	+14 lines, -34 lines	0 comments	Download
A	chrome/browser/gtk/external_protocol_dialog_gtk.h	View	1 2 3	1 chunk	+29 lines, -0 lines	0 comments	Download
A	chrome/browser/gtk/external_protocol_dialog_gtk.cc	View	1 2 3	1 chunk	+92 lines, -0 lines	0 comments	Download
M	chrome/browser/views/external_protocol_dialog.h	View	1 2 3	4 chunks	+9 lines, -24 lines	0 comments	Download
M	chrome/browser/views/external_protocol_dialog.cc	View	1 2 3	5 chunks	+17 lines, -17 lines	0 comments	Download
M	chrome/chrome.gyp	View	1 2 3	1 chunk	+2 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Evan Stade

works on windows, Tony is handling fixing the grit generator

11 years, 3 months ago (2009-09-03 21:24:59 UTC) #2

Mike Mammarella

11 years, 3 months ago (2009-09-03 21:27:32 UTC) #3

On 2009/09/03 21:24:59, Evan Stade wrote:
> works on windows, Tony is handling fixing the grit generator

LGTM once the windows trybot turns green :)

Expand Messages | Collapse Messages