Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2477)

Unified Diff: chrome/browser/resources/md_user_manager/create_profile.js

Issue 1939933002: MD User Manager: Supervised user checkbox is always displaying (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@md-user-manager-stylesheets
Patch Set: Fixed broken browser test Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/md_user_manager/create_profile.js
diff --git a/chrome/browser/resources/md_user_manager/create_profile.js b/chrome/browser/resources/md_user_manager/create_profile.js
index 63cfa78c672462a98f915630b6d70932dd14f853..94f48309268e2560b44c01691d1d8dbcf78ea9d8 100644
--- a/chrome/browser/resources/md_user_manager/create_profile.js
+++ b/chrome/browser/resources/md_user_manager/create_profile.js
@@ -131,8 +131,9 @@ Polymer({
},
/**
- * Handles tap events from dynamically created links in warning/error messages
- * pushed by the browser.
+ * Handles tap events from:
+ * - links within dynamic warning/error messages pushed from the browser.
+ * - the 'noSignedInUserMessage' i18n string.
* @param {!Event} event
* @private
*/
@@ -142,6 +143,9 @@ Polymer({
if (element.id == 'supervised-user-import-existing') {
dpapad 2016/05/03 17:30:26 I can't find any element with this ID in the HTML?
Moe 2016/05/03 20:30:10 Yes. These are both dynamically added. The comment
this.onImportUserTap_(event);
event.preventDefault();
+ } else if (element.id == 'sign-in-to-chrome') {
dpapad 2016/05/03 17:30:26 Same here.
Moe 2016/05/03 20:30:10 Same as above.
+ this.browserProxy_.openUrlInLastActiveProfileBrowser(element.href);
+ event.preventDefault();
}
// TODO(mahmadi): handle tap event on '#reauth' to re-auth the custodian.
},

Powered by Google App Engine
This is Rietveld 408576698