MD User Manager: Supervised user checkbox is always displaying

chrome/browser/resources/md_user_manager/create_profile.js

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 /**
  * @fileoverview 'create-profile' is a page that contains controls for creating
  * a (optionally supervised) profile, including choosing a name, and an avatar.
  */
 (function() {
 /**
@@ skipping 109 matching lines @@
       'profile-icons-received', this.handleProfileIcons_.bind(this));
     this.addWebUIListener(
       'profile-defaults-received', this.handleProfileDefaults_.bind(this));
     this.addWebUIListener(
       'signedin-users-received', this.handleSignedInUsers_.bind(this));
 
     this.browserProxy_.getAvailableIcons();
     this.browserProxy_.getSignedInUsers();
 
     // Alias on 'this' to use in html.
     this.NO_USER_SELECTED = NO_USER_SELECTED;

[dpapad, 2016/05/03 17:30:26]

Nit: Can this be moved in the properties {} section? See similar example where
an enum is mirrored such that it can be used in HTML,
https://code.google.com/p/chromium/codesearch#chromium/src/chrome/browser/res....

   },
 
   /**
-   * Handles tap events from dynamically created links in warning/error messages
-   * pushed by the browser.
+   * Handles tap events from:
+   * - links within dynamic warning/error messages pushed from the browser.
+   * - the 'noSignedInUserMessage' i18n string.
    * @param {!Event} event
    * @private
    */
   onTap_: function(event) {
     var element = Polymer.dom(event).rootTarget;
 
     if (element.id == 'supervised-user-import-existing') {

[dpapad, 2016/05/03 17:30:26]

I can't find any element with this ID in the HTML? Can you point me to where it
is defined? Is it being added dynamically? If so, can you add a comment
explaining where the ID comes from?

[Moe, 2016/05/03 20:30:10]

Yes. These are both dynamically added. The comment above the function explains
this.

       this.onImportUserTap_(event);
       event.preventDefault();
+    } else if (element.id == 'sign-in-to-chrome') {

[dpapad, 2016/05/03 17:30:26]

Same here.

[Moe, 2016/05/03 20:30:10]

Same as above.

+      this.browserProxy_.openUrlInLastActiveProfileBrowser(element.href);
+      event.preventDefault();
     }
     // TODO(mahmadi): handle tap event on '#reauth' to re-auth the custodian.
   },
 
   /**
    * Handler for when the profile icons are pushed from the browser.
    * @param {!Array<string>} iconUrls
    * @private
    */
   handleProfileIcons_: function(iconUrls) {
@@ skipping 257 matching lines @@
    * Computed binding that returns True if there are any signed-in users.
    * @param {!Array<!SignedInUser>} signedInUsers signed-in users.
    * @return {boolean}
    * @private
    */
   isSignedIn_: function(signedInUsers) {
     return signedInUsers.length > 0;
   }
 });
 }());