MD User Manager: Supervised user checkbox is always displaying

chrome/browser/resources/md_user_manager/create_profile.js

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 /**
  * @fileoverview 'create-profile' is a page that contains controls for creating
  * a (optionally supervised) profile, including choosing a name, and an avatar.
  */
 (function() {
 /**
@@ skipping 114 matching lines @@
 
     this.browserProxy_.getAvailableIcons();
     this.browserProxy_.getSignedInUsers();
 
     // Alias on 'this' to use in html.
     this.NO_USER_SELECTED = NO_USER_SELECTED;
   },
 
   /**
    * Handles tap events from dynamically created links in warning/error messages
-   * pushed by the browser.
+   * pushed by the browser as well as the noSignedInUserMessage i18n string.

[tommycli, 2016/05/02 19:10:13]

Would this comment be more readable as?

Handles tap events from:
 - links within dynamic warning/error messages pushed from the browser
 - the 'noSignedInUserMessage' i18n string

[Moe, 2016/05/02 20:34:56]

Done.

    * @param {!Event} event
    * @private
    */
   onTap_: function(event) {
     var element = Polymer.dom(event).rootTarget;
 
     if (element.id == 'supervised-user-import-existing') {
       this.onImportUserTap_(event);
       event.preventDefault();
+    } else if (element.id == 'sign-in-to-chrome') {
+      this.browserProxy_.openUrlInLastActiveProfileBrowser(element.href);
+      event.preventDefault();

[tommycli, 2016/05/02 19:10:13]

You could move this line outside the if blocks

[Moe, 2016/05/02 20:34:57]

This handler handles all tap events on the page. We only want to call
preventDefault when the tap is coming from one of these elements. I can wrap the
if-elseif chain inside another if condition that checks if the source of the
event is a link and move this line to the outer if condition. But I don't think
that's easier to read.

[tommycli, 2016/05/02 21:57:49]

You are correct. My mistake :)

     }
     // TODO(mahmadi): handle tap event on '#reauth' to re-auth the custodian.
   },
 
   /**
    * Handler for when the profile icons are pushed from the browser.
    * @param {!Array<string>} iconUrls
    * @private
    */
   handleProfileIcons_: function(iconUrls) {
@@ skipping 257 matching lines @@
    * Computed binding that returns True if there are any signed-in users.
    * @param {!Array<!SignedInUser>} signedInUsers signed-in users.
    * @return {boolean}
    * @private
    */
   isSignedIn_: function(signedInUsers) {
     return signedInUsers.length > 0;
   }
 });
 }());